You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Kyle Purtell (Jira)" <ji...@apache.org> on 2022/07/01 20:12:00 UTC
[jira] [Closed] (HBASE-18808) Ineffective config check in BackupLogCleaner#getDeletableFiles()
[ https://issues.apache.org/jira/browse/HBASE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kyle Purtell closed HBASE-18808.
---------------------------------------
> Ineffective config check in BackupLogCleaner#getDeletableFiles()
> ----------------------------------------------------------------
>
> Key: HBASE-18808
> URL: https://issues.apache.org/jira/browse/HBASE-18808
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Reid Chan
> Priority: Major
> Fix For: 2.0.0-alpha-4, 2.0.0
>
> Attachments: HBASE-18808.master.001.patch
>
>
> Here is related code:
> {code}
> if (this.getConf() == null || !BackupManager.isBackupEnabled(getConf())) {
> LOG.warn("Backup is not enabled. Check your " + BackupRestoreConstants.BACKUP_ENABLE_KEY
> + " setting");
> return files;
> }
> {code}
> However, in setConf() we don't store the Configuration where backup is disabled:
> {code}
> public void setConf(Configuration config) {
> // If backup is disabled, keep all members null
> if (!config.getBoolean(BackupRestoreConstants.BACKUP_ENABLE_KEY,
> BackupRestoreConstants.BACKUP_ENABLE_DEFAULT)) {
> LOG.warn("Backup is disabled - allowing all wals to be deleted");
> return;
> }
> {code}
> This means that once config with backup enabled is remembered, it won't go to disabled state.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)