You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by sa...@apache.org on 2011/09/21 14:38:54 UTC

svn commit: r1173596 - /ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java

Author: sascharodekamp
Date: Wed Sep 21 12:38:53 2011
New Revision: 1173596

URL: http://svn.apache.org/viewvc?rev=1173596&view=rev
Log:
FIX: Impossible ClassCast (https://issues.apache.org/jira/browse/OFBIZ-4421) A fix from Dimitri Unruh: The FeatureSetConstraint cast will always throw a ClassCastException. The patch fixes the instanceof if condition.  

Modified:
    ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java

Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java?rev=1173596&r1=1173595&r2=1173596&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java Wed Sep 21 12:38:53 2011
@@ -1310,7 +1310,7 @@ public class ProductSearch {
         @Override
         public boolean equals(Object obj) {
             ProductSearchConstraint psc = (ProductSearchConstraint) obj;
-            if (psc instanceof FeatureConstraint) {
+            if (psc instanceof FeatureSetConstraint) {
                 FeatureSetConstraint that = (FeatureSetConstraint) psc;
                 if (this.productFeatureIdSet == null) {
                     if (that.productFeatureIdSet != null) {