You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/10 12:17:49 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4676: Display public ip addresses for shared network
ravening opened a new pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676
### Description
If a vm belongs to shared network then display the list
of ip addresses available which can be used to assign for
secondary IP addresses.
Also display "Public IP addresses" tab for shared networks
List all public ip address in shared network
Display the list of ip address while adding secondary ip instead of user input box
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811711522
@ravening
An error occurred while navigating to the IP address, network resource page
- Public IP resource:
- Network:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-810733503
ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811858083
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#discussion_r604871925
##########
File path: ui/src/views/compute/InstanceTab.vue
##########
@@ -444,6 +461,15 @@ export default {
this.fetchPublicIps(record.nic.networkid)
}
},
+ onAcquireSecondaryIPAddress (record) {
+ if (record.nic.type === 'Shared') {
+ this.editNicResource = record.nic
+ this.editNetworkId = record.nic.networkid
Review comment:
@ravening I believe L466-467 need to be moved outside the if block as in a case where we have one nic on an Isolated network & one on a shared network; if you first attempt adding a secondary IP for the nic on a shared network and then do the same for the nic on Isolated network, it continues to show the shared n/ws public ips
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-778168172
@ravening does this rely on some code changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811860273
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-85)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811696350
ping @ravening cc @weizhouapache - any progress/update on this?
@utchoang cc @svenvogel - can you help review/test this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-779784136
> > > @ravening does this rely on some code changes ?
> >
> >
> > @weizhouapache dont think so.. public ip address should be listed by default
>
> @ravening but listing ips in shared network does not work, right ?
@weizhouapache I can display it
```
(local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
"count": 59,
"publicipaddress": [
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-778182690
> > @ravening does this rely on some code changes ?
>
> @weizhouapache dont think so.. public ip address should be listed by default
@ravening but listing ips in shared network does not work, right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-810991474
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-81)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-809326710
@ravening Could you please address the conflict. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811857882
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-778169199
> @ravening does this rely on some code changes ?
@weizhouapache dont think so.. public ip address should be listed by default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811711522
An error occurred while navigating to the IP address, network resource page
- Public IP resource:
- Network:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-810989017
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-779825631
> > > > @ravening does this rely on some code changes ?
> > >
> > >
> > > @weizhouapache dont think so.. public ip address should be listed by default
> >
> >
> > @ravening but listing ips in shared network does not work, right ?
>
> @weizhouapache I can display it
>
> ```
> (local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
> {
> "count": 59,
> "publicipaddress": [
> ```
@ravening ok.
I tested with 4.15.1.0, it worked.
by the way, forvirtualnetwork should be 'false', and networkid should be passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-811802891
> @ravening
> An error occurred while navigating to the IP address, network resource page
>
> * Public IP resource:
> 
> 
> * Network:
> 
> 
@utchoang @Pearl1594 can you guys test/review the code again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4676: Display public ip addresses for shared network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#issuecomment-810989246
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org