You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Dawid Dabrowski (JIRA)" <ji...@apache.org> on 2012/08/16 20:53:37 UTC
[jira] [Created] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Dawid Dabrowski created HIVE-3391:
-------------------------------------
Summary: Keep the original query in HiveDriverRunHookContextImpl
Key: HIVE-3391
URL: https://issues.apache.org/jira/browse/HIVE-3391
Project: Hive
Issue Type: Improvement
Reporter: Dawid Dabrowski
Priority: Minor
It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Patch Available (was: Open)
Patch is available on phabricator
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442769#comment-13442769 ]
Dawid Dabrowski commented on HIVE-3391:
---------------------------------------
https://reviews.facebook.net/D4923
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Open (was: Patch Available)
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Attachment: HIVE-3391.patch.txt
https://reviews.facebook.net/D4923 - latest revision from here
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3391:
--------------------------------
Component/s: Logging
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Components: Logging
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: HIVE-3391.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442685#comment-13442685 ]
Kevin Wilfong commented on HIVE-3391:
-------------------------------------
Could you add a testcase, e.g. write a driver run hook that prints the command to stdout, and add a simple unit test which consists of a query using that hook https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-AddaUnitTest
It'll help prevent anyone from accidentally breaking this change.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Patch Available (was: Open)
https://reviews.facebook.net/D4923
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3391:
---------------------------------
Status: Open (was: Patch Available)
@Dawid: Please see my comments on phabricator. Thanks.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455051#comment-13455051 ]
Hudson commented on HIVE-3391:
------------------------------
Integrated in Hive-trunk-h0.21 #1667 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1667/])
HIVE-3391. Keep the original query in HiveDriverRunHookContextImpl. (Dawid Dabrowski via kevinwilfong) (Revision 1384247)
Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384247
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContext.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContextImpl.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/DriverTestHook.java
* /hive/trunk/ql/src/test/queries/clientpositive/driverhook.q
* /hive/trunk/ql/src/test/results/clientpositive/driverhook.q.out
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Components: Logging
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: HIVE-3391.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Patch Available (was: Open)
https://reviews.facebook.net/D4923
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Patch Available (was: Open)
Simple change. I added another field in HiveDriverRunHookContextImpl, which is command - the original command that Hive is about to execute. No other changes have been made.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Attachment: HIVE-3391.1.patch.txt
Please, review my code.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Attachment: (was: HIVE-3391.1.patch.txt)
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450827#comment-13450827 ]
Kevin Wilfong commented on HIVE-3391:
-------------------------------------
@Dawid: could you please put your latest patch in the Attachments section.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski reassigned HIVE-3391:
-------------------------------------
Assignee: Dawid Dabrowski
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3391:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Status: Resolved (was: Patch Available)
Committed, thanks Dawid.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Components: Logging
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: HIVE-3391.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3391:
---------------------------------
Status: Open (was: Patch Available)
@Dawid: Please submit a review request on phabricator or reviews.apache.org
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work logged] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel\#worklog-{worklog.getId()} ]
Dawid Dabrowski logged work on HIVE-3391:
-----------------------------------------
Author: Dawid Dabrowski
Created on: 27/Aug/12 21:03
Start Date: 20/Aug/12 21:02
Worklog Time Spent: 96h
Issue Time Tracking
-------------------
Worklog Id: (was: 14035)
Time Spent: 96h
Remaining Estimate: 0h (was: 72h)
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442766#comment-13442766 ]
Carl Steinbach commented on HIVE-3391:
--------------------------------------
Great. Can you please provide a link?
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3391:
---------------------------------
Status: Open (was: Patch Available)
More comments on phabricator. Thanks.
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Dawid Dabrowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Dabrowski updated HIVE-3391:
----------------------------------
Status: Patch Available (was: Open)
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3391) Keep the original query in
HiveDriverRunHookContextImpl
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450824#comment-13450824 ]
Kevin Wilfong commented on HIVE-3391:
-------------------------------------
+1 running tests
> Keep the original query in HiveDriverRunHookContextImpl
> -------------------------------------------------------
>
> Key: HIVE-3391
> URL: https://issues.apache.org/jira/browse/HIVE-3391
> Project: Hive
> Issue Type: Improvement
> Reporter: Dawid Dabrowski
> Assignee: Dawid Dabrowski
> Priority: Minor
> Attachments: HIVE-3391.1.patch.txt
>
> Original Estimate: 72h
> Time Spent: 96h
> Remaining Estimate: 0h
>
> It'd be useful to have access to the original query in hooks. The hook that's executed first is HiveDriverRunHook, let's add it there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira