You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mivanac (GitHub)" <gi...@apache.org> on 2020/02/19 15:07:16 UTC

[GitHub] [geode] mivanac opened pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [*] Is your initial contribution a single, squashed commit?

- [*] Does `gradlew build` run cleanly?

- [*] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
The other acquireConnection() method uses a hard-coded timeout of 45000L, though I don't know why that is.  Why does this version use 15000L? We should remove the "test hook" comment because this method is used in GatewaySenderEventRemoteDispatcher.initializeConnection().

[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
The other acquireConnection() method uses a hard-coded timeout of 45000L, though I don't know why that is.  Why does this version use 15000L? We shoudl remove the "test hook" comment because this method is used in GatewaySenderEventRemoteDispatcher.initializeConnection().

[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
We should get rid of the javadoc on this method.  It's hiding a more complete javadoc in the ConnectionManager interface.

[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Posted by "mivanac (GitHub)" <gi...@apache.org>.
Updated

[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4719: GEODE-6536: Added retry in borrowConnection/single hop

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
If onlyUseExistingCnx is true then the acquireTimeout parameter is ignored.

[ Full content available at: https://github.com/apache/geode/pull/4719 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org