You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "lxfeng1997 (via GitHub)" <gi...@apache.org> on 2026/01/31 03:04:11 UTC
Re: [PR] feat: add QueryContext for AT mode [incubator-seata-go]
lxfeng1997 commented on code in PR #1039:
URL: https://github.com/apache/incubator-seata-go/pull/1039#discussion_r2748765937
##########
pkg/datasource/sql/conn_at.go:
##########
@@ -122,7 +164,7 @@ func (c *ATConn) createOnceTxContext(ctx context.Context) bool {
return onceTx
}
-func (c *ATConn) createNewTxOnExecIfNeed(ctx context.Context, f func() (types.ExecResult, error)) (types.ExecResult, error) {
+func (c *ATConn) createNewTxOnExecIfNeed(ctx context.Context, isQuery bool, f func() (types.ExecResult, error)) (types.ExecResult, error) {
Review Comment:
I suggest defining a new function instead of adding a parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org