You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@gmail.com> on 2007/07/01 02:18:41 UTC

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

On 6/30/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> Sorry, I was busy and I have not time to report my research results.
>
> My patch almost complete and I need somebody's eyes to look and
> confirm that I'm on right way (or say that I'm on wrong way :)


I've built trunk r25598 + Stefan/Ivan's patch and posted the binaries at:

http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8682&expandFolder=8682&folderID=8682

so people with multi-language setups can test them a bit.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Mark Phippard <ma...@gmail.com>.
On 7/5/07, D.J. Heap <dj...@gmail.com> wrote:
> On 7/5/07, Ivan Zhakov <ch...@gmail.com> wrote:
> [snip]
> > I committed my patch and found that these tests fails on your buildbot
> > slave even with VS2005. But they work on my computer. Could you see
> > what happens on your buildbot slave?
>
>
> Yes I will as soon as I can -- probably this Saturday, I'm swamped
> until then, sorry. :(

Just an fyi, but my MSVC 6.0 build passed all tests (ra_local + fsfs).
 There is still the problem that win-tests.py will not run if the
apriconv.dll is not present.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/5/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> I committed my patch and found that these tests fails on your buildbot
> slave even with VS2005. But they work on my computer. Could you see
> what happens on your buildbot slave?


Yes I will as soon as I can -- probably this Saturday, I'm swamped
until then, sorry. :(

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/7/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> Is it happens only with 'Debug' build, but doesn't happen with 'Release'?


It fails quite consistently with Release, somewhat sporadically with Debug.


>
> May be there are some problems with DLLs? Did you try to build with
> --disable-shared? Another source of problems may be that there are
> different APR libraries installed somewhere.


Haven't tried --disable-shared (the fs-test.exe is statically linked
anyway), but I'm fairly certain the APR libraries are the correct ones
-- while debugging I watched which ones were loaded.


>
> Also could you check how is your APR built: Is it built with
> APR_HAS_UNICODE_FS or not?


Yes it is.


>
> Do you have some antivirus software installed?


No.

I will back out the patch and see what happens...The buildbot had been
running pretty clean up until that day, as I recall, though -- and I
got the same failures on a different VM with the VC6 build as well.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Ivan Zhakov <ch...@gmail.com>.
On 7/8/07, D.J. Heap <dj...@gmail.com> wrote:
> On 7/7/07, Ivan Zhakov <ch...@gmail.com> wrote:
> [snip]
> > And of course primary question: Does it work without my patch? Because
> > these failures can be related to new txn generation code, committed by
> > Blair in r25430.
> >
>
>
> I'm building with trunk r25679 and after backing out r25650, the
> fs-test.exe passes all tests again.  So, either the patch is bringing
> out some lurking problem, or it is affecting the fs stuff in some way
> I can't seem to figure out.
>
It seems I found way to reproduce problem even without my patch. Many
fs-test will fail on Windows if you just remove time part from
generated transaction name in fs_fs. See patch:

Index: subversion/libsvn_fs_fs/fs_fs.c
===================================================================
--- subversion/libsvn_fs_fs/fs_fs.c	(revision 25654)
+++ subversion/libsvn_fs_fs/fs_fs.c	(working copy)
@@ -3195,7 +3195,7 @@
       *p = '-';

   process_id = getpid();
-  now = apr_time_now();
+  now = 0; /* It's for testing purposes only! should apr_time_now(). */

   unique_basename = apr_psprintf(pool, "%s-%05d-%" APR_TIME_T_FMT,
                                  hostname_str, process_id, now);
Index: subversion/libsvn_subr/utf.c
===================================================================
--- subversion/libsvn_subr/utf.c	(revision 25654)
+++ subversion/libsvn_subr/utf.c	(working copy)
@@ -253,7 +253,7 @@
     pool = apr_hash_pool_get(xlate_handle_hash);

   /* Try to create a handle. */
-#if defined( WIN32)
+#if 0
   apr_err = svn_subr__win32_xlate_open(&handle, topage, frompage, pool);
 #elif defined(AS400)
   apr_err = apr_xlate_open(&handle, (int)topage, (int)frompage, pool);

So it seems the problem of my patch that it made running Subversion
faster and we got two transactions in the same time :)

Now I'm trying to figure out why this transaction generation code
fails on Windows.

-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/7/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> And of course primary question: Does it work without my patch? Because
> these failures can be related to new txn generation code, committed by
> Blair in r25430.
>


I'm building with trunk r25679 and after backing out r25650, the
fs-test.exe passes all tests again.  So, either the patch is bringing
out some lurking problem, or it is affecting the fs stuff in some way
I can't seem to figure out.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Ivan Zhakov <ch...@gmail.com>.
On 7/8/07, Ivan Zhakov <ch...@gmail.com> wrote:
> On 7/7/07, D.J. Heap <dj...@gmail.com> wrote:
> > On 7/5/07, Ivan Zhakov <ch...@gmail.com> wrote:
> > [snip]
> > > > svn_tests: Reference to non-existent node
> > > > '1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
> > > > 'test-repo-check-root-revision'
> > > > FAIL:  fs-test.exe 26: ensure accurate storage of root node
> > [snip]
> > > I committed my patch and found that these tests fails on your buildbot
> > > slave even with VS2005. But they work on my computer. Could you see
> > > what happens on your buildbot slave?
> >
> >
> > I've spent a few hours trying to debug through this now and haven't
> > found out exactly what is going on.  It doesn't happen when I step
> > through the code with a debugger, and it is somewhat sporadic in the
> > debug build anyway.  So I've had to put in sleeps, printf traces, etc.
> > to get anywhere and those sometimes stop the failure from happening as
> > well.
> >
> > But in all the failures I've seen, it comes down to a transaction
> > child-node file not being there -- whether it was never created or has
> > been deleted or something, I'm not sure yet.  Any ideas or suggestions
> > on where to look or what to look for?
> >
> Is it happens only with 'Debug' build, but doesn't happen with 'Release'?
>
> May be there are some problems with DLLs? Did you try to build with
> --disable-shared? Another source of problems may be that there are
> different APR libraries installed somewhere.
>
> Also could you check how is your APR built: Is it built with
> APR_HAS_UNICODE_FS or not?
>
> Do you have some antivirus software installed?
>
And of course primary question: Does it work without my patch? Because
these failures can be related to new txn generation code, committed by
Blair in r25430.

-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Ivan Zhakov <ch...@gmail.com>.
On 7/7/07, D.J. Heap <dj...@gmail.com> wrote:
> On 7/5/07, Ivan Zhakov <ch...@gmail.com> wrote:
> [snip]
> > > svn_tests: Reference to non-existent node
> > > '1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
> > > 'test-repo-check-root-revision'
> > > FAIL:  fs-test.exe 26: ensure accurate storage of root node
> [snip]
> > I committed my patch and found that these tests fails on your buildbot
> > slave even with VS2005. But they work on my computer. Could you see
> > what happens on your buildbot slave?
>
>
> I've spent a few hours trying to debug through this now and haven't
> found out exactly what is going on.  It doesn't happen when I step
> through the code with a debugger, and it is somewhat sporadic in the
> debug build anyway.  So I've had to put in sleeps, printf traces, etc.
> to get anywhere and those sometimes stop the failure from happening as
> well.
>
> But in all the failures I've seen, it comes down to a transaction
> child-node file not being there -- whether it was never created or has
> been deleted or something, I'm not sure yet.  Any ideas or suggestions
> on where to look or what to look for?
>
Is it happens only with 'Debug' build, but doesn't happen with 'Release'?

May be there are some problems with DLLs? Did you try to build with
--disable-shared? Another source of problems may be that there are
different APR libraries installed somewhere.

Also could you check how is your APR built: Is it built with
APR_HAS_UNICODE_FS or not?

Do you have some antivirus software installed?


-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/5/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> > svn_tests: Reference to non-existent node
> > '1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
> > 'test-repo-check-root-revision'
> > FAIL:  fs-test.exe 26: ensure accurate storage of root node
[snip]
> I committed my patch and found that these tests fails on your buildbot
> slave even with VS2005. But they work on my computer. Could you see
> what happens on your buildbot slave?


I've spent a few hours trying to debug through this now and haven't
found out exactly what is going on.  It doesn't happen when I step
through the code with a debugger, and it is somewhat sporadic in the
debug build anyway.  So I've had to put in sleeps, printf traces, etc.
to get anywhere and those sometimes stop the failure from happening as
well.

But in all the failures I've seen, it comes down to a transaction
child-node file not being there -- whether it was never created or has
been deleted or something, I'm not sure yet.  Any ideas or suggestions
on where to look or what to look for?

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Ivan Zhakov <ch...@gmail.com>.
On 7/1/07, D.J. Heap <dj...@gmail.com> wrote:
> On 6/30/07, D.J. Heap <dj...@gmail.com> wrote:
> > On 6/30/07, Ivan Zhakov <ch...@gmail.com> wrote:
> > [snip]
> > > Sorry, I was busy and I have not time to report my research results.
> > >
> > > My patch almost complete and I need somebody's eyes to look and
> > > confirm that I'm on right way (or say that I'm on wrong way :)
> >
> >
> > I've built trunk r25598 + Stefan/Ivan's patch and posted the binaries at:
> >
> > http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8682&expandFolder=8682&folderID=8682
> >
> > so people with multi-language setups can test them a bit.
> >
>
>
> FYI, I get two fs-test failures with this patch on WinXP with VC6:
>
> PASS:  fs-test.exe 25: create and modify large file (seed=2683120967)
> CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-large-file-integrity
> svn_tests: Reference to non-existent node
> '1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
> 'test-repo-check-root-revision'
> FAIL:  fs-test.exe 26: ensure accurate storage of root node
> PASS:  fs-test.exe 27: svn_fs_node_created_rev test
> CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-node-created-rev
> svn_tests: Reference to non-existent node
> '2.0.tDJ-VM-XP-VS6-02704-1183257584937500-1' in filesystem
> 'test-repo-check-related'
> FAIL:  fs-test.exe 28: test svn_fs_check_related
> PASS:  fs-test.exe 29: test complex copies (branches)
>
I committed my patch and found that these tests fails on your buildbot
slave even with VS2005. But they work on my computer. Could you see
what happens on your buildbot slave?

-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/3/07, Daniel Rall <dl...@collab.net> wrote:
[snip]
> > I don't have any strong feelings about the temporary memory
> > management, but I would tend to prefer a subpool, I think, unless it
> > turns out to be a performance issue as Stefan thinks it might.
>
> Is this question in relation to svn_subr__win32_xlate_to_stringbuf()?
>


Right.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Daniel Rall <dl...@collab.net>.
On Sun, 01 Jul 2007, D.J. Heap wrote:

> On 7/1/07, Ivan Zhakov <ch...@gmail.com> wrote:
...
> >Btw, what do you think about patch itself?
>
> As you and Stefan said, using the API rather than the registry will
> probably be more robust and I think the win32 specific stuff might be
> better off in its own file.

Just a nitpick, but some of the formatting is pretty inconsistent with
the rest of the code base (use of Hungarian notation, lack of
whitespace between data type and value in type casts, etc.).

> I don't have any strong feelings about the temporary memory
> management, but I would tend to prefer a subpool, I think, unless it
> turns out to be a performance issue as Stefan thinks it might.

Is this question in relation to svn_subr__win32_xlate_to_stringbuf()?

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/1/07, Ivan Zhakov <ch...@gmail.com> wrote:
[snip]
> It's strange, because it works for me: VS2005, fsfs.


Hmm, yes, strange -- VS2005 works for me too.  I'll try to debug
through the  fs-test failures on VC6 to see what's going on when I
can.


>
> Btw, what do you think about patch itself?
>


As you and Stefan said, using the API rather than the registry will
probably be more robust and I think the win32 specific stuff might be
better off in its own file.

I don't have any strong feelings about the temporary memory
management, but I would tend to prefer a subpool, I think, unless it
turns out to be a performance issue as Stefan thinks it might.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by Ivan Zhakov <ch...@gmail.com>.
On 7/1/07, D.J. Heap <dj...@gmail.com> wrote:
> On 6/30/07, D.J. Heap <dj...@gmail.com> wrote:
> > On 6/30/07, Ivan Zhakov <ch...@gmail.com> wrote:
> > [snip]
> > > Sorry, I was busy and I have not time to report my research results.
> > >
> > > My patch almost complete and I need somebody's eyes to look and
> > > confirm that I'm on right way (or say that I'm on wrong way :)
> >
> >
> > I've built trunk r25598 + Stefan/Ivan's patch and posted the binaries at:
> >
> > http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8682&expandFolder=8682&folderID=8682
> >
> > so people with multi-language setups can test them a bit.
> >
>
>
> FYI, I get two fs-test failures with this patch on WinXP with VC6:
>
> PASS:  fs-test.exe 25: create and modify large file (seed=2683120967)
> CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-large-file-integrity
> svn_tests: Reference to non-existent node
> '1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
> 'test-repo-check-root-revision'
> FAIL:  fs-test.exe 26: ensure accurate storage of root node
> PASS:  fs-test.exe 27: svn_fs_node_created_rev test
> CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-node-created-rev
> svn_tests: Reference to non-existent node
> '2.0.tDJ-VM-XP-VS6-02704-1183257584937500-1' in filesystem
> 'test-repo-check-related'
> FAIL:  fs-test.exe 28: test svn_fs_check_related
> PASS:  fs-test.exe 29: test complex copies (branches)
>
>
> All other ra_local tests passed.
>
It's strange, because it works for me: VS2005, fsfs.

Btw, what do you think about patch itself?

-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Posted by "D.J. Heap" <dj...@gmail.com>.
On 6/30/07, D.J. Heap <dj...@gmail.com> wrote:
> On 6/30/07, Ivan Zhakov <ch...@gmail.com> wrote:
> [snip]
> > Sorry, I was busy and I have not time to report my research results.
> >
> > My patch almost complete and I need somebody's eyes to look and
> > confirm that I'm on right way (or say that I'm on wrong way :)
>
>
> I've built trunk r25598 + Stefan/Ivan's patch and posted the binaries at:
>
> http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8682&expandFolder=8682&folderID=8682
>
> so people with multi-language setups can test them a bit.
>


FYI, I get two fs-test failures with this patch on WinXP with VC6:

PASS:  fs-test.exe 25: create and modify large file (seed=2683120967)
CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-large-file-integrity
svn_tests: Reference to non-existent node
'1.0.tDJ-VM-XP-VS6-02704-1183257584562500-1' in filesystem
'test-repo-check-root-revision'
FAIL:  fs-test.exe 26: ensure accurate storage of root node
PASS:  fs-test.exe 27: svn_fs_node_created_rev test
CLEANUP: C:/Temp/tmp/tests/subversion/tests/libsvn_fs/test-repo-node-created-rev
svn_tests: Reference to non-existent node
'2.0.tDJ-VM-XP-VS6-02704-1183257584937500-1' in filesystem
'test-repo-check-related'
FAIL:  fs-test.exe 28: test svn_fs_check_related
PASS:  fs-test.exe 29: test complex copies (branches)


All other ra_local tests passed.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org