[jira] [Commented] (SPARK-4766) ML Estimator Params should subclass Transformer Params

["Joseph K. Bradley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257495#comment-14257495 ] 

Joseph K. Bradley commented on SPARK-4766:
------------------------------------------

This will require modifying Params.inheritValues so that inheritance is handled properly.  (It should check against the child's parameters.)

> ML Estimator Params should subclass Transformer Params
> ------------------------------------------------------
>
>                 Key: SPARK-4766
>                 URL: https://issues.apache.org/jira/browse/SPARK-4766
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 1.2.0
>            Reporter: Joseph K. Bradley
>            Assignee: Joseph K. Bradley
>
> Currently, in spark.ml, both Transformers and Estimators extend the same Params classes.  There should be one Params class for the Transformer and one for the Estimator, where the Estimator params class extends the Transformer one.
> E.g., it is weird to be able to do:
> {code}
> val model: LogisticRegressionModel = ...
> model.getMaxIter()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org