You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/22 11:28:18 UTC
[GitHub] [cloudstack-primate] ravening opened a new pull request #553: Dont display "isolated network" section for SG enabled zone
ravening opened a new pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553
In the "add network" form, dont display the form for
isolated network if its an advanced zone with security
group enabled.
Steps:
Create an advanced zone with security groups enabled.
Login to ui, navigate to networks section and click on "Add network"
This should show only L2 and guest network option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664177671
@davidjumani @utchoang can you help review this? Thnx
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664907971
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664909610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664856275
@davidjumani made changes to CreateL2NetworkForm so that it can be created in all zones
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664177859
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#discussion_r460721718
##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -95,8 +95,9 @@ export default {
isAdvancedZoneWithoutSGAvailable () {
for (const i in this.actionZones) {
const zone = this.actionZones[i]
- if (zone.networktype === 'Advanced' && zone.securitygroupsenabled !== true) {
- return true
+ // Dont display isolated networks for advanced with sg enabled
+ if (zone.networktype === 'Advanced' && zone.securitygroupsenabled === true) {
+ return false
Review comment:
Would this break if there are multiple zones and one with SG Enabled ?
##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -95,8 +95,9 @@ export default {
isAdvancedZoneWithoutSGAvailable () {
for (const i in this.actionZones) {
const zone = this.actionZones[i]
- if (zone.networktype === 'Advanced' && zone.securitygroupsenabled !== true) {
- return true
+ // Dont display isolated networks for advanced with sg enabled
+ if (zone.networktype === 'Advanced' && zone.securitygroupsenabled === true) {
+ return false
}
}
return true
Review comment:
return false over here instead ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #553: Dont display "isolated network" section for SG enabled zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #553:
URL: https://github.com/apache/cloudstack-primate/pull/553#issuecomment-664181809
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/553 (JID-2656)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org