You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Created) (JIRA)" <ji...@apache.org> on 2011/11/16 19:08:52 UTC
[jira] [Created] (HBASE-4800) Result.compareResults is incorrect
Result.compareResults is incorrect
----------------------------------
Key: HBASE-4800
URL: https://issues.apache.org/jira/browse/HBASE-4800
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.4, 0.92.0, 0.94.0
Reporter: Lars Hofhansl
A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
This condition:
{code}
if (!ourKVs[i].equals(replicatedKVs[i]) &&
!Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
throw new Exception("This result was different: "
{code}
should be
{code}
if (!ourKVs[i].equals(replicatedKVs[i]) ||
!Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
throw new Exception("This result was different: "
{code}
Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4800) Result.compareResults is incorrect
Posted by "Lars Hofhansl (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-4800.
----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed to 0.90, 0.92, and trunk.
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4800) Result.compareResults is incorrect
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151402#comment-13151402 ]
stack commented on HBASE-4800:
------------------------------
+1
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4800) Result.compareResults is incorrect
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4800:
---------------------------------
Fix Version/s: 0.90.5
0.94.0
0.92.0
Assignee: Lars Hofhansl
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4800) Result.compareResults is incorrect
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4800:
---------------------------------
Attachment: 4800.txt
Simple patch with test
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4800) Result.compareResults is incorrect
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151521#comment-13151521 ]
Hudson commented on HBASE-4800:
-------------------------------
Integrated in HBase-TRUNK #2448 (See [https://builds.apache.org/job/HBase-TRUNK/2448/])
HBASE-4800 Result.compareResults is incorrect (James Taylor and Lars H)
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4800) Result.compareResults is incorrect
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151594#comment-13151594 ]
Hudson commented on HBASE-4800:
-------------------------------
Integrated in HBase-0.92 #137 (See [https://builds.apache.org/job/HBase-0.92/137/])
HBASE-4800 Result.compareResults is incorrect (James Taylor and Lars H)
larsh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Result.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
> Result.compareResults is incorrect
> ----------------------------------
>
> Key: HBASE-4800
> URL: https://issues.apache.org/jira/browse/HBASE-4800
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.4, 0.92.0, 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: 4800.txt
>
>
> A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
> This condition:
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) &&
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> should be
> {code}
> if (!ourKVs[i].equals(replicatedKVs[i]) ||
> !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
> throw new Exception("This result was different: "
> {code}
> Just checked, this is wrong in all branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira