You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/27 13:58:00 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #16414: Workflow on Windows and MacOS scheduled daily
sandynz opened a new pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414
Purpose:
- Currently, CI has several jobs, include Linux-JDK8/Linux-JDK11/Linux-JDK17, windows-JDK8, macos-JDK8. windows-JDK8 and macos-JDK8 are the slowest jobs. Since ShardingSphere run on Linux at the most time, we'll test several JDK versions on Linux, and there should be almost no failure on Windows and MacOS when it pass on Linux. If we run workflow on Windows and MacOS daily but not every PR or push, it could speedup CI.
Changes proposed in this pull request:
- Workflow on Windows and MacOS scheduled daily. 1) update concurrency group, since push to master and schedule both will trigger CI on master branch, 2) add condition for `windows` and `macos` jobs, just trigger CI when `github.event_name` is `schedule`.
It might need some discussion about whether need to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo merged pull request #16414: Workflow on Windows and MacOS scheduled daily
Posted by GitBox <gi...@apache.org>.
totalo merged pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16414: Workflow on Windows and MacOS scheduled daily
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414#issuecomment-1079966355
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16414](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18db84d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3edbeb983d31cc06fa8d88cced74be4c4c32da28?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3edbeb9) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16414 +/- ##
=========================================
Coverage 60.77% 60.77%
Complexity 2089 2089
=========================================
Files 3319 3319
Lines 50176 50176
Branches 8598 8598
=========================================
Hits 30494 30494
Misses 17137 17137
Partials 2545 2545
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3edbeb9...18db84d](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #16414: Workflow on Windows and MacOS scheduled daily
Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414#issuecomment-1080084549
@totalo thanks, I'll check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #16414: Workflow on Windows and MacOS scheduled daily
Posted by GitBox <gi...@apache.org>.
totalo commented on pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414#issuecomment-1079961849
<img width="917" alt="image" src="https://user-images.githubusercontent.com/29777558/160290361-ff3d20f2-be45-4f4b-aad4-1b61b4dba918.png">, There may be another problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #16414: Workflow on Windows and MacOS scheduled daily
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #16414:
URL: https://github.com/apache/shardingsphere/pull/16414#issuecomment-1079966355
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16414](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3800df) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3edbeb983d31cc06fa8d88cced74be4c4c32da28?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3edbeb9) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16414 +/- ##
============================================
+ Coverage 60.77% 60.79% +0.01%
Complexity 2089 2089
============================================
Files 3319 3319
Lines 50176 50176
Branches 8598 8598
============================================
+ Hits 30494 30502 +8
+ Misses 17137 17128 -9
- Partials 2545 2546 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/16414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...sql/ral/common/updatable/AlterInstanceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/16414/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi91cGRhdGFibGUvQWx0ZXJJbnN0YW5jZUhhbmRsZXIuamF2YQ==) | `68.75% <0.00%> (+68.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3edbeb9...b3800df](https://codecov.io/gh/apache/shardingsphere/pull/16414?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org