You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/18 10:11:32 UTC
[GitHub] [doris] DongLiang-0 opened a new pull request, #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
DongLiang-0 opened a new pull request, #13444:
URL: https://github.com/apache/doris/pull/13444
# Proposed changes
Issue Number: close #xxx
## Problem summary
[Improvement][SET-PROPERTY]Support for set query_timeout property
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on a diff in pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
DongLiang-0 commented on code in PR #13444:
URL: https://github.com/apache/doris/pull/13444#discussion_r998271880
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##########
@@ -452,6 +469,9 @@ public List<List<String>> fetchProperty() {
// exec mem limit
result.add(Lists.newArrayList(PROP_EXEC_MEM_LIMIT, String.valueOf(commonProperties.getExecMemLimit())));
+ // timeout limit
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13444:
URL: https://github.com/apache/doris/pull/13444#issuecomment-1284141072
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.1 seconds
load time: 584 seconds
storage size: 17154768628 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221019225024_clickbench_pr_31450.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13444:
URL: https://github.com/apache/doris/pull/13444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on a diff in pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
DongLiang-0 commented on code in PR #13444:
URL: https://github.com/apache/doris/pull/13444#discussion_r998272611
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -557,6 +563,11 @@ public void checkTimeout(long now) {
// Only kill
killFlag = true;
+ } else if (delta > userQueryTimeout * 1000) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13444:
URL: https://github.com/apache/doris/pull/13444#discussion_r998042360
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -146,6 +146,12 @@ public class ConnectContext {
private SessionContext sessionContext;
+ private long userQueryTimeout;
+
+ public void setUserQueryTimeoutMap(long queryTimeout) {
Review Comment:
```suggestion
public void setUserQueryTimeout(long queryTimeout) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -557,6 +563,11 @@ public void checkTimeout(long now) {
// Only kill
killFlag = true;
+ } else if (delta > userQueryTimeout * 1000) {
Review Comment:
If querytimeout is set in property, it should override the querytimeou in session variable
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##########
@@ -452,6 +469,9 @@ public List<List<String>> fetchProperty() {
// exec mem limit
result.add(Lists.newArrayList(PROP_EXEC_MEM_LIMIT, String.valueOf(commonProperties.getExecMemLimit())));
+ // timeout limit
Review Comment:
```suggestion
// query timeout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property
Posted by GitBox <gi...@apache.org>.
DongLiang-0 commented on PR #13444:
URL: https://github.com/apache/doris/pull/13444#issuecomment-1291343589
@morningman PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org