[jira] [Commented] (OOZIE-3331) SparkOptionsSplitter inconsistency

["Andras Salamon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587272#comment-16587272 ] 

Andras Salamon commented on OOZIE-3331:
---------------------------------------

I've added a work in progress patch which contains two unit tests. Both of the examples (one is the listed in the javadoc) should remain unquoted, but one of the tests fail currently.

> SparkOptionsSplitter inconsistency
> ----------------------------------
>
>                 Key: OOZIE-3331
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3331
>             Project: Oozie
>          Issue Type: Test
>          Components: action
>    Affects Versions: 5.0.0
>            Reporter: Andras Salamon
>            Assignee: Andras Salamon
>            Priority: Minor
>         Attachments: OOZIE-3331-wip.patch
>
>
> According to the [javadoc comment|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java#L125-L138] of SparkOptionsSplitter  we should unquote the option value if and only if it has quotes at both ends, and doesn't have any quotes in between. One of the listed examples shows that the following should remain quoted:
> {noformat}
> key="value1 value2" "value3 value4"{noformat}
> The current code unquotes this example which contradicts the javadoc comment.
> We should either change the javadoc or the code (after defining the correct behaviour) and we should also add a unit test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)