You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/07 01:23:19 UTC
[GitHub] [trafficserver] masaori335 opened a new pull request #7795: Make HTTP/2 configs reloadable
masaori335 opened a new pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795
The doc says HTTP/2 configs are reloadable, but all HTTP/2 configs require restarting ATS to apply.
This introduces `Http2Config` and `Http2ConfigParams` like other subsystems have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#issuecomment-834080535
Close this. All HTTP/2 configs are reloadable. I misunderstand what `REC_EstablishStaticConfigInt32U()` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#discussion_r627865170
##########
File path: proxy/http2/Http2Frame.cc
##########
@@ -76,11 +76,6 @@ Http2DataFrame::write_to(MIOBuffer *iobuffer) const
int64_t
Http2HeadersFrame::write_to(MIOBuffer *iobuffer) const
{
- // Validation
Review comment:
I just got rid of this validation, because the `_hdr_block_len` is already checked before making `Http2HeadersFrame` and too noisy to read or pass the config from `ua_session` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#issuecomment-834065775
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 closed pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 closed pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#issuecomment-834065775
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 edited a comment on pull request #7795: Make HTTP/2 configs reloadable
Posted by GitBox <gi...@apache.org>.
masaori335 edited a comment on pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#issuecomment-834080535
Close this. I misunderstand what `REC_EstablishStaticConfigInt32U()` does.
All HTTP/2 configs are reloadable. They're not scoped, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org