[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1191: MINIFICPP-1566 - Annotate maximum allowed threads for processors

[GitBox <gi...@apache.org>]

fgerlits commented on a change in pull request #1191:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1191#discussion_r731952116



##########
File path: libminifi/include/core/Processor.h
##########
@@ -144,13 +144,14 @@ class Processor : public Connectable, public ConfigurableComponent, public std::
   }
 
   // Set Processor Maximum Concurrent Tasks
-  void setMaxConcurrentTasks(uint8_t tasks) {
-    max_concurrent_tasks_ = tasks;
-  }
-  // Get Processor Maximum Concurrent Tasks
-  uint8_t getMaxConcurrentTasks() const {
-    return (max_concurrent_tasks_);
+  void setMaxConcurrentTasks(const uint8_t tasks) override;

Review comment:
       minor, but this `const` doesn't do anything, so I would remove it from the base class and the other override rather than add it here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org