You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/01/26 07:04:19 UTC
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/16709
[SPARK-19333][SPARKR] Add Apache License headers to R files
## What changes were proposed in this pull request?
add header
## How was this patch tested?
Manual run to check vignettes html is created properly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rfilelicense
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16709.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16709
----
commit 63a035621934d99bd4cb475985090f08c46e1dfc
Author: Felix Cheung <fe...@hotmail.com>
Date: 2017-01-26T06:31:11Z
license
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16709#discussion_r97962380
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -10,6 +10,23 @@ vignette: >
\usepackage[utf8]{inputenc}
---
+<!--
--- End diff --
I don't think we need license headers in doc files -- I don't think others have this.
You could add one to `DESCRIPTION` for good measure but it's really conf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16709
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16709
merged to master, branch-2.1, branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16709
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72015/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16709#discussion_r98082326
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -10,6 +10,23 @@ vignette: >
\usepackage[utf8]{inputenc}
---
+<!--
--- End diff --
right, this file actually contains source code that gets run to generate output that gets included (as a html file) in the Apache source release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16709
**[Test build #72015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72015/testReport)** for PR 16709 at commit [`63a0356`](https://github.com/apache/spark/commit/63a035621934d99bd4cb475985090f08c46e1dfc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16709
**[Test build #72015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72015/testReport)** for PR 16709 at commit [`63a0356`](https://github.com/apache/spark/commit/63a035621934d99bd4cb475985090f08c46e1dfc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16709#discussion_r98072136
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -10,6 +10,23 @@ vignette: >
\usepackage[utf8]{inputenc}
---
+<!--
--- End diff --
I have worked with a few Apache projects that do this in doc though.
I understand we don't. I'm fine either way but since the JIRA is opened there really isn't any file without license except for DESCRIPTION (doesn't support comment, already has a license tag) and NAMESPACE (which is really a build file, and very often tool generated).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16709#discussion_r98076370
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -10,6 +10,23 @@ vignette: >
\usepackage[utf8]{inputenc}
---
+<!--
--- End diff --
FWIW the ASF policy statement talks about source files only: http://www.apache.org/legal/release-policy.html#license-headers
Is this source for docs? maybe so. I think it's fine as-is then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org