You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by oz...@apache.org on 2004/08/03 11:37:48 UTC
cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/method UnlockMethod.java AbstractWebdavMethod.java MkcolMethod.java PutMethod.java AclMethod.java AbstractMultistatusResponseMethod.java PropPatchMethod.java LockMethod.java
ozeigermann 2004/08/03 02:37:48
Modified: src/webdav/server/org/apache/slide/webdav/method
UnlockMethod.java AbstractWebdavMethod.java
MkcolMethod.java PutMethod.java AclMethod.java
AbstractMultistatusResponseMethod.java
PropPatchMethod.java LockMethod.java
Log:
Removed methodNeedsTransactionSupport method as it
always returned true anyway
Revision Changes Path
1.39 +3 -10 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/UnlockMethod.java
Index: UnlockMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/UnlockMethod.java,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- UnlockMethod.java 2 Aug 2004 16:36:02 -0000 1.38
+++ UnlockMethod.java 3 Aug 2004 09:37:47 -0000 1.39
@@ -280,13 +280,6 @@
}
}
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
private void checkPreconditions() throws SlideException {
Enumeration locksAll = lock.enumerateLocks(slideToken, resourcePath,
true);
1.41 +4 -19 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AbstractWebdavMethod.java
Index: AbstractWebdavMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AbstractWebdavMethod.java,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- AbstractWebdavMethod.java 2 Aug 2004 16:36:02 -0000 1.40
+++ AbstractWebdavMethod.java 3 Aug 2004 09:37:47 -0000 1.41
@@ -337,7 +337,7 @@
}
}
- if (!slideToken.isExternalTransaction() && methodNeedsTransactionSupport()) {
+ if (!slideToken.isExternalTransaction()) {
token.begin();
transactionIsStarted = true;
if (this instanceof ReadMethod) {
@@ -453,21 +453,6 @@
}
// ------------------------------------------------------ Protected Methods
-
-
- /**
- * Return true if the method needs transaction support.
- * Return true if the method needs transaction support, e.g.
- * the methods put, proppatch would need TA support. The
- * methods get, propfind would not need transaction support.
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- // this method should return false and e.g. PutMethod should
- // overwrite it to true, but PropFind creates a RevisionDescriptors
- // on the fly
- }
-
/**
* Read request contents.
1.36 +3 -13 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java
Index: MkcolMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- MkcolMethod.java 2 Aug 2004 16:36:02 -0000 1.35
+++ MkcolMethod.java 3 Aug 2004 09:37:47 -0000 1.36
@@ -268,15 +268,5 @@
}
-
-
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
-
}
1.81 +3 -14 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PutMethod.java
Index: PutMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PutMethod.java,v
retrieving revision 1.80
retrieving revision 1.81
diff -u -r1.80 -r1.81
--- PutMethod.java 2 Aug 2004 16:36:01 -0000 1.80
+++ PutMethod.java 3 Aug 2004 09:37:47 -0000 1.81
@@ -494,17 +494,6 @@
return super.getErrorCode(e);
}
}
-
-
-
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
-
}
1.44 +3 -11 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AclMethod.java
Index: AclMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AclMethod.java,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- AclMethod.java 2 Aug 2004 16:36:02 -0000 1.43
+++ AclMethod.java 3 Aug 2004 09:37:48 -0000 1.44
@@ -266,13 +266,5 @@
throw new WebdavException( statusCode );
}
}
-
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
}
1.36 +3 -11 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AbstractMultistatusResponseMethod.java
Index: AbstractMultistatusResponseMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/AbstractMultistatusResponseMethod.java,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- AbstractMultistatusResponseMethod.java 2 Aug 2004 16:36:01 -0000 1.35
+++ AbstractMultistatusResponseMethod.java 3 Aug 2004 09:37:48 -0000 1.36
@@ -103,14 +103,6 @@
}
/**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
-
- /**
* Checks if a 207 should be generated. A 207 is generated when the request URI is a
* collection and exactely one nested exception is present and the request URI and
* the nested exception URI are identical.
1.86 +3 -13 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PropPatchMethod.java
Index: PropPatchMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PropPatchMethod.java,v
retrieving revision 1.85
retrieving revision 1.86
diff -u -r1.85 -r1.86
--- PropPatchMethod.java 2 Aug 2004 16:36:01 -0000 1.85
+++ PropPatchMethod.java 3 Aug 2004 09:37:48 -0000 1.86
@@ -588,16 +588,6 @@
return propstat;
}
-
-
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
-
/**
* Checks the (DeltaV) preconditions
* <ul>
1.69 +3 -11 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/LockMethod.java
Index: LockMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/LockMethod.java,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -r1.68 -r1.69
--- LockMethod.java 2 Aug 2004 16:36:02 -0000 1.68
+++ LockMethod.java 3 Aug 2004 09:37:48 -0000 1.69
@@ -536,13 +536,5 @@
}
}
-
- /**
- * Returns true
- */
- protected boolean methodNeedsTransactionSupport() {
- return true;
- }
-
}
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org