[jira] [Commented] (KYLIN-3416) Kylin bitmap null pointer exception when "group by" is an expression

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716086#comment-16716086 ] 

ASF GitHub Bot commented on KYLIN-3416:
---------------------------------------

coveralls commented on issue #380: KYLIN-3416 Group by with expression can not aggregate exactly
URL: https://github.com/apache/kylin/pull/380#issuecomment-446060593
 
 
   ## Pull Request Test Coverage Report for [Build 3942](https://coveralls.io/builds/20562765)
   
   * **0** of **7**   **(0.0%)**  changed or added relevant lines in **4** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.001%**) to **25.954%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/realization/SQLDigest.java](https://coveralls.io/builds/20562765/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Frealization%2FSQLDigest.java#L105) | 0 | 1 | 0.0%
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java](https://coveralls.io/builds/20562765/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPContext.java#L136) | 0 | 1 | 0.0%
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPAggregateRel.java](https://coveralls.io/builds/20562765/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPAggregateRel.java#L273) | 0 | 2 | 0.0%
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/20562765/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L609) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **7** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/20562765/badge)](https://coveralls.io/builds/20562765) |
   | :-- | --: |
   | Change from base [Build 3940](https://coveralls.io/builds/20562085): |  -0.001% |
   | Covered Lines: | 17817 |
   | Relevant Lines: | 68648 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kylin bitmap null pointer exception when "group by" is an expression
> --------------------------------------------------------------------
>
>                 Key: KYLIN-3416
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3416
>             Project: Kylin
>          Issue Type: Bug
>          Components: Query Engine
>    Affects Versions: v2.3.1
>            Reporter: Lemont
>            Assignee: Chao Long
>            Priority: Blocker
>             Fix For: v2.6.0
>
>
> Hi,team:
>   Ithink there is a conflict between dimensional aggregation and count distinct.
> For example:
> select
>  (1524931200 - biz_time)/(30*86400),
>  count(DISTINCT id) id
>  from test
> where pt ='20180621'
>  group by (1524931200 - biz_time)/(30*86400)
> Caused by: java.lang.NullPointerException
>  at org.apache.kylin.measure.bitmap.RoaringBitmapCounter.getMutableBitmap(RoaringBitmapCounter.java:58)
>  at org.apache.kylin.measure.bitmap.RoaringBitmapCounter.orWith(RoaringBitmapCounter.java:72)
>  at org.apache.kylin.measure.bitmap.BitmapAggregator.aggregate(BitmapAggregator.java:43)
>  at org.apache.kylin.measure.bitmap.BitmapDistinctCountAggFunc.add(BitmapDistinctCountAggFunc.java:31)
>  
> The problem cased by  GTCubeStorageQueryBase.isNeedStorageAggregation
> There are three dimension int the cube,the sql use cuboid 5 and the cuboid.getColumns is
> pt,bize_time.
> The groupD is bize_time and singleValueD is pt.
> So isNeedStorageAggregation return false.
> But in fact this sql need storage agregation because the group is (1524931200 - biz_time)/(30*86400) not only biz_time 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)