You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by su...@apache.org on 2022/04/21 04:15:02 UTC
[druid] branch master updated: Emit vectorized metric dimension by default (#12464)
This is an automated email from the ASF dual-hosted git repository.
suneet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 4c6ba73823 Emit vectorized metric dimension by default (#12464)
4c6ba73823 is described below
commit 4c6ba73823bc0561dad1ea9c0088238922438f23
Author: Rohan Garg <77...@users.noreply.github.com>
AuthorDate: Thu Apr 21 09:44:55 2022 +0530
Emit vectorized metric dimension by default (#12464)
---
.../org/apache/druid/query/DefaultQueryMetrics.java | 2 +-
.../apache/druid/query/DefaultQueryMetricsTest.java | 19 +++++++++++++++++++
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
index 095fa17d03..ac20cc248d 100644
--- a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
+++ b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
@@ -201,7 +201,7 @@ public class DefaultQueryMetrics<QueryType extends Query<?>> implements QueryMet
@Override
public void vectorized(final boolean vectorized)
{
- // Emit nothing by default.
+ setDimension("vectorized", vectorized);
}
@Override
diff --git a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
index 5091ae08a5..7658ffd841 100644
--- a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
+++ b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
@@ -156,4 +156,23 @@ public class DefaultQueryMetricsTest
Assert.assertEquals("query/node/bytes", actualEvent.get("metric"));
Assert.assertEquals(10L, actualEvent.get("value"));
}
+
+ @Test
+ public void testVectorizedDimensionInMetrics()
+ {
+ CachingEmitter cachingEmitter = new CachingEmitter();
+ ServiceEmitter serviceEmitter = new ServiceEmitter("", "", cachingEmitter);
+ DefaultQueryMetrics<Query<?>> queryMetrics = new DefaultQueryMetrics<>();
+ queryMetrics.vectorized(true);
+ queryMetrics.reportSegmentTime(0).emit(serviceEmitter);
+ Map<String, Object> actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
+ Assert.assertEquals(7, actualEvent.size());
+ Assert.assertTrue(actualEvent.containsKey("feed"));
+ Assert.assertTrue(actualEvent.containsKey("timestamp"));
+ Assert.assertEquals("", actualEvent.get("host"));
+ Assert.assertEquals("", actualEvent.get("service"));
+ Assert.assertEquals("query/segment/time", actualEvent.get("metric"));
+ Assert.assertEquals(0L, actualEvent.get("value"));
+ Assert.assertEquals(true, actualEvent.get("vectorized"));
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org