You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2025/02/20 18:33:23 UTC
[PR] chore: Upgrade AG Grid to use tree shaking [superset]
kgabryje opened a new pull request, #32334:
URL: https://github.com/apache/superset/pull/32334
### SUMMARY
Upgrade AG Grid to version 33. This version introduced [modules](https://www.ag-grid.com/javascript-data-grid/modules/), which let's us specify exactly which parts of the library we use and tree-shake the rest, thus improving the bundle size.
Additionally, I wrapped some props passed to AG Grid in `useMemo` to avoid rerenders
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
### TESTING INSTRUCTIONS
The AG Grid table in SQL Lab should work like before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1965980644
##########
superset-frontend/src/setup/setupAGGridModules.ts:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import {
+ ModuleRegistry,
+ ColumnAutoSizeModule,
+ ColumnHoverModule,
+ RowAutoHeightModule,
+ RowStyleModule,
+ PaginationModule,
+ CellStyleModule,
+ TextFilterModule,
+ NumberFilterModule,
+ DateFilterModule,
+ ExternalFilterModule,
+ CsvExportModule,
+ ColumnApiModule,
+ RowApiModule,
+ CellApiModule,
+ RenderApiModule,
+ ClientSideRowModelModule,
Review Comment:
There isn't, the closest thing is ColumnApiModule which we include here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2674695608
@kgabryje Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/13458847218). Action: **up**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2675248277
> wait. it looks like the header menu has gone in this version. Could you check what is missing?
Which header menu? I'm comparing before/after side by side and I can't see a difference. Also nothing happens on right-click in both versions.
In the recording, I'm running master on localhost, and the other tab is the ephemeral env for this PR.
https://github.com/user-attachments/assets/4ad81d63-58f5-459a-93c0-f2c1e2f76daf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2674688476
@kgabryje Ephemeral environment spinning up at http://35.90.243.148:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1965960003
##########
superset-frontend/src/setup/setupAGGridModules.ts:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import {
+ ModuleRegistry,
+ ColumnAutoSizeModule,
+ ColumnHoverModule,
+ RowAutoHeightModule,
+ RowStyleModule,
+ PaginationModule,
+ CellStyleModule,
+ TextFilterModule,
+ NumberFilterModule,
+ DateFilterModule,
+ ExternalFilterModule,
+ CsvExportModule,
+ ColumnApiModule,
+ RowApiModule,
+ CellApiModule,
+ RenderApiModule,
+ ClientSideRowModelModule,
Review Comment:
Could you check if there's an api for column header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2682069687
@kgabryje Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/13522945418). Action: **up**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #32334:
URL: https://github.com/apache/superset/pull/32334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2674662211
@kgabryje Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/13453257517). Action: **up**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1966290409
##########
superset-frontend/src/setup/setupAGGridModules.ts:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import {
+ ModuleRegistry,
+ ColumnAutoSizeModule,
+ ColumnHoverModule,
+ RowAutoHeightModule,
+ RowStyleModule,
+ PaginationModule,
+ CellStyleModule,
+ TextFilterModule,
+ NumberFilterModule,
+ DateFilterModule,
+ ExternalFilterModule,
+ CsvExportModule,
+ ColumnApiModule,
+ RowApiModule,
+ CellApiModule,
+ RenderApiModule,
+ ClientSideRowModelModule,
Review Comment:
CustomFilterModule might be the one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1965909948
##########
superset-frontend/src/SqlLab/components/ResultSet/ResultSet.test.tsx:
##########
@@ -363,7 +368,7 @@ describe('ResultSet', () => {
);
});
const { getByRole } = setup(mockedProps, mockStore(initialState));
- expect(getByRole('treegrid')).toBeInTheDocument();
+ expect(getByRole('grid')).toBeInTheDocument();
Review Comment:
For some reason, in jest runtime, the ag grid root had a role "grid", not "treegrid"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1967457129
##########
superset-frontend/src/components/GridTable/index.tsx:
##########
@@ -216,21 +231,16 @@ function GridTable<RecordType extends object>({
`}
>
<AgGridReact
+ // TODO: migrate to Theme API - https://www.ag-grid.com/react-data-grid/theming-migration/
+ theme="legacy"
Review Comment:
Oh weird it looked right on my localhost... maybe I had some cached styles. Should work fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1967463907
##########
superset-frontend/src/setup/setupAGGridModules.ts:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import {
+ ModuleRegistry,
+ ColumnAutoSizeModule,
+ ColumnHoverModule,
+ RowAutoHeightModule,
+ RowStyleModule,
+ PaginationModule,
+ CellStyleModule,
+ TextFilterModule,
+ NumberFilterModule,
+ DateFilterModule,
+ ExternalFilterModule,
+ CsvExportModule,
+ ColumnApiModule,
+ RowApiModule,
+ CellApiModule,
+ RenderApiModule,
+ ClientSideRowModelModule,
Review Comment:
Done, filtering works now 👍
<img width="1319" alt="image" src="https://github.com/user-attachments/assets/a2c5f077-b19b-455d-bc23-afc46c192299" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2682100611
@kgabryje Ephemeral environment spinning up at http://54.70.87.11:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2673969403
@kgabryje Ephemeral environment spinning up at http://52.12.1.165:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2675799657
> > wait. it looks like the header menu has gone in this version. Could you check what is missing?
>
> Which header menu? I'm comparing before/after side by side and I can't see a difference. Also nothing happens on right-click in both versions.
>
> In the recording, I'm running master on localhost, and the other tab is the ephemeral env for this PR.
>
> Screen.Recording.2025-02-21.at.19.18.25.mov
I found that it's not related to this change but this [ant dropdown migration](https://github.com/apache/superset/pull/31972/files#diff-b35ab989924f8adea06aafc3caa5c8814d9aaf24146d7e0505cf25a675b8f785R101).
I will fix the dropdown menu issue separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2682107787
@justinpark could you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2673950860
@kgabryje Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/13453257517). Action: **up**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1966307562
##########
superset-frontend/src/components/GridTable/index.tsx:
##########
@@ -216,21 +231,16 @@ function GridTable<RecordType extends object>({
`}
>
<AgGridReact
+ // TODO: migrate to Theme API - https://www.ag-grid.com/react-data-grid/theming-migration/
+ theme="legacy"
Review Comment:
with this theme value, the existing ag-theme-quartz styles are broken.
Please migrate to theme api first to apply the theme name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2675082384
@kgabryje I pinged @justinpark and he'll take a look. Please don't merge it just yet 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2674722535
@kgabryje Ephemeral environment spinning up at http://52.12.1.165:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #32334:
URL: https://github.com/apache/superset/pull/32334#issuecomment-2672355602
@justinpark could you please verify if I included all modules that we use in the table in SQL Lab? There's a tool that helps selecting the correct modules [here](https://www.ag-grid.com/javascript-data-grid/modules/#selecting-modules)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org