You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/27 04:07:06 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35666: [SPARK-38338][BUILD][TESTS] Remove test dependency on `hamcrest`
LuciferYang opened a new pull request #35666:
URL: https://github.com/apache/spark/pull/35666
### What changes were proposed in this pull request?
[SPARK-7081](https://issues.apache.org/jira/browse/SPARK-7081) introduces test dependency on `hamcrest` to extend assertion syntax.
However, `hamcrest` is not very popular now (compared with `assertj`). On the other hand, `hamcrest` is not widely used in Spark code, so this pr use `JUnit4` api to replace the corresponding assertion and remove the dependence on `hamcrest`.
### Why are the changes needed?
Clean up weak dependencies.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35666:
URL: https://github.com/apache/spark/pull/35666#issuecomment-1053811811
thanks @srowen @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35666:
URL: https://github.com/apache/spark/pull/35666#issuecomment-1053752755
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #35666:
URL: https://github.com/apache/spark/pull/35666#issuecomment-1053094775
On the other hand, we can use `assertj` instead of `hamcrest`, `assertj` also use [APL 2.0](https://github.com/assertj/assertj-core/blob/main/LICENSE.txt) . It seems that `assertj` is also popular and it declares that it supports Java 17 after `3.21.0` at the same time:
- https://mvnrepository.com/artifact/org.assertj/assertj-core
- https://assertj.github.io/doc/#assertj-core-3-21-0-release-notes
cc @dongjoon-hyun @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35666:
URL: https://github.com/apache/spark/pull/35666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35666: [SPARK-38338][BUILD][CORE] Remove test dependency on `hamcrest`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35666:
URL: https://github.com/apache/spark/pull/35666#issuecomment-1053094775
On the other hand, we can use `assertj` instead of `hamcrest`. It seems that `assertj` is also popular and it declares that it supports Java 17 after `3.21.0` at the same time:
- https://mvnrepository.com/artifact/org.assertj/assertj-core
- https://assertj.github.io/doc/#assertj-core-3-21-0-release-notes
cc @dongjoon-hyun @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org