You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "kusalk (via GitHub)" <gi...@apache.org> on 2024/08/03 10:25:49 UTC
[PR] WW-5454 Log warnings on startup for disabled critical security features [struts]
kusalk opened a new pull request, #1010:
URL: https://github.com/apache/struts/pull/1010
WW-5454
--
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5454 Log warnings on startup for disabled critical security features [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk merged PR #1010:
URL: https://github.com/apache/struts/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5454 Log warnings on startup for disabled critical security features [struts]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1010:
URL: https://github.com/apache/struts/pull/1010#issuecomment-2266668945
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1010) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1010&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1010&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1010&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [84.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1010&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1010&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1010)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5454 Log warnings on startup for disabled critical security features [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on code in PR #1010:
URL: https://github.com/apache/struts/pull/1010#discussion_r1702680866
##########
core/src/main/java/com/opensymphony/xwork2/util/DebugUtils.java:
##########
@@ -37,4 +42,12 @@ public static void notifyDeveloperOfError(Logger log, Object action, String mess
}
}
+ /**
+ * @since 7.0
+ */
+ public static void logWarningForFirstOccurrence(String key, Logger log, String msg, Object... args) {
Review Comment:
This method isn't really a `DebugUtils` method but couldn't think of a better home - can create a separate class if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org