[GitHub] [ignite] ibessonov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework.

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework.
URL: https://github.com/apache/ignite/pull/6814#discussion_r346283416
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/util/nio/GridNioServer.java
 ##########
 @@ -293,12 +320,12 @@ private GridNioServer(
         int sndQueueLimit,
         boolean directMode,
         boolean daemon,
-        GridNioMetricsListener metricsLsnr,
         GridNioMessageWriterFactory writerFactory,
         IgnitePredicate<Message> skipRecoveryPred,
         IgniteBiInClosure<GridNioSession, Integer> msgQueueLsnr,
         boolean readWriteSelectorsAssign,
         @Nullable GridWorkerListener workerLsnr,
+        @Nullable MetricRegistry mreg,
 
 Review comment:
   Let me please argue with you about this particular constructor =)
   I totally forgot that it's a private constructor and only "GridNioServer.Builder#build" invokes it. There's no point in splitting it because no one will invoke other constructor with fewer parameters. Let's leave it as is.
   
   Just in case - GridAbstractCommunicationClient constructor will be fixed as you asked. I't not about arguing for the sake of arguing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services