[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #2345: drivers/mtd/mtd_progmem.c: fix progmem_log2 parameter type to match prototype

[GitBox <gi...@apache.org>]

juniskane commented on a change in pull request #2345:
URL: https://github.com/apache/incubator-nuttx/pull/2345#discussion_r527653254



##########
File path: drivers/mtd/mtd_progmem.c
##########
@@ -131,7 +131,7 @@ static struct progmem_dev_s g_progmem =
  *
  ****************************************************************************/
 
-static int32_t progmem_log2(uint32_t blocksize)
+static int32_t progmem_log2(size_t blocksize)

Review comment:
       @yamt: I don't think so. The various _ioctl_ function pointers in _include/nuttx/fs/ioctl.h_ and elsewhere have _arg_ as unsigned long because that is supposed to be a generic argument that can represent other things than just sizes of memory areas. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org