You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/09/09 17:51:08 UTC
[jira] [Commented] (ZOOKEEPER-1176) Remove dead code and basic
cleanup in DataTree
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101292#comment-13101292 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1176:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
> Remove dead code and basic cleanup in DataTree
> ----------------------------------------------
>
> Key: ZOOKEEPER-1176
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1176
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1176.patch
>
>
> - DataTree members scount, initialized and method listACLEquals are never used
> - transform if(!C) B else A to if(C) A else B (removes one indirection to follow for the brain)
> - remove unused imports and one annotation
> - add method getApproximateDataSize to DataNode (I work towards an immutable DataNode without public properties)
> - move assignments (lastPrefix = getMaxPrefixWithQuota(path)) out of if statements
> - combine nested if statements: if A if B then C => if A && B => C
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira