[GitHub] [pinot] dmyang commented on a diff in pull request #9697: AdaptiveServerSelection: Fix timer

[GitBox <gi...@apache.org>]

dmyang commented on code in PR #9697:
URL: https://github.com/apache/pinot/pull/9697#discussion_r1010890179


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/server/routing/stats/ServerRoutingStatsManager.java:
##########
@@ -47,8 +48,13 @@ public class ServerRoutingStatsManager {
   private final PinotConfiguration _config;
   private volatile boolean _isEnabled;
   private ConcurrentHashMap<String, ServerRoutingStatsEntry> _serverQueryStatsMap;
+
+  // Main executor service for collecting and aggregating stats for all servers.
   private ExecutorService _executorService;
 
+  // ScheduledExecutorServer for processing periodic tasks like decay.
+  private ScheduledExecutorService _periodicTaskExecutor;

Review Comment:
   Could the periodic tasks share the same executor service by changing the main executor service to a scheduled one? That way the threadpool size can still be modified w/ pinot config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org