You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Matthew Gregan <ki...@orcon.net.nz> on 2003/11/24 09:19:59 UTC
[PATCH] Basic SMTP AUTH support for mailer.py
Hello,
Another tiny patch for one of the hook scripts. Adds support for SMTP
AUTH in the SMTPOutput class if the user supplies and username and
password. Comments appreciated.
* tools/hook-scripts/mailer/mailer.py:
Use SMTP AUTH in the SMTPOutput class if a username and password
have been supplied in the config file.
* tools/hook-scripts/mailer/mailer.conf.example:
Example of SMTP AUTH configuration.
Cheers,
-mjg
--
Matthew Gregan |/
/| kinetik@orcon.net.nz
Re: [PATCH] Basic SMTP AUTH support for mailer.py
Posted by Matthew Gregan <ki...@orcon.net.nz>.
On Mon, Nov 24, 2003 at 05:55:18PM +0100, Erik Huelsmann wrote:
> > Matthew Gregan <ki...@orcon.net.nz> writes:
> >
> > > Hello,
> > >
> > > Another tiny patch for one of the hook scripts. Adds support for SMTP
> > > AUTH in the SMTPOutput class if the user supplies and username and
> > > password. Comments appreciated.
> >
> > Applied in revision 7834. Thanks.
> There was a TAB in the source for indenting. Mailer.py did not have any tabs
> for that purpose yet, so I removed it.
> Matthew, please try not to use tabs for indenting. Otherwise: thanks for the
> patch.
Sorry, I didn't notice. I'll watch out for tabs next time.
Cheers,
-mjg
--
Matthew Gregan |/
/| kinetik@orcon.net.nz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Basic SMTP AUTH support for mailer.py
Posted by Erik Huelsmann <e....@gmx.net>.
> Matthew Gregan <ki...@orcon.net.nz> writes:
>
> > Hello,
> >
> > Another tiny patch for one of the hook scripts. Adds support for SMTP
> > AUTH in the SMTPOutput class if the user supplies and username and
> > password. Comments appreciated.
>
> Applied in revision 7834. Thanks.
Does the rule about tabs
There was a TAB in the source for indenting. Mailer.py did not have any tabs
for that purpose yet, so I removed it.
Matthew, please try not to use tabs for indenting. Otherwise: thanks for the
patch.
bye,
Erik.
--
NEU F�R ALLE - GMX MediaCenter - f�r Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gru�, GMX FotoService
Jetzt kostenlos anmelden unter http://www.gmx.net
+++ GMX - die erste Adresse f�r Mail, Message, More! +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Basic SMTP AUTH support for mailer.py
Posted by "C. Michael Pilato" <cm...@collab.net>.
Matthew Gregan <ki...@orcon.net.nz> writes:
> Hello,
>
> Another tiny patch for one of the hook scripts. Adds support for SMTP
> AUTH in the SMTPOutput class if the user supplies and username and
> password. Comments appreciated.
Applied in revision 7834. Thanks.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Basic SMTP AUTH support for mailer.py
Posted by John Szakmeister <jo...@szakmeister.net>.
+ if self.cfg.is_set('general.smtp_username'):
+ server.login(self.cfg.general.smtp_username, self.cfg.general.smtp_password)
It looks like the second line has a tab inserted in there. Other than that,
the patch looks good to me.
I do have one question, and pardon me for my ignorance, but is storing the
password in this file a security concern?
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org