[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

["Sandro Martini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034664#comment-13034664 ] 

Sandro Martini commented on PIVOT-744:
--------------------------------------

Hi, 
I've just seen than before your patch I have to make another little change (in TerraListViewSkin and probably even in TerraTableViewSkin and TerraTreeViewSkin) ... because one my commit last week broke something there.
I'll tell you as soon as possible, one time all is working good as before (I have to add some other test to ensure all is good).

Note that at the moment that fix in TerraListViewSkin is this:
                 if (button == Mouse.Button.LEFT) {
-                    if (selectMode != ListView.SelectMode.NONE
-                        && !listView.isItemSelected(itemIndex)) {
-                        listView.setSelectedIndex(itemIndex);
-                    }
-


> ListView with SelectMode.Multi does not allow deselection when all elements are selected
> ----------------------------------------------------------------------------------------
>
>                 Key: PIVOT-744
>                 URL: https://issues.apache.org/jira/browse/PIVOT-744
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk-terra
>    Affects Versions: 2.0
>            Reporter: Edvin Syse
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: TerraListViewSkinDeselect.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> If you select all items in a ListView that allows multiple selection, there is not way to deselect using the keyboard. One would expect that releasing shift and moving the arrows would revert to selecting a single element, but this is not the case. The supplied patch allows deselection in the following manner:
> 1. If you select all elements with the keyboard "downwards", release shift and then press Keyboard.KeyCode.UP, the "next last" element in the list is selected.
> 2. If you select all elements with the keyboard "upwards", release shift and then press Keyboard.KeyCode.DOWN, the "next first" element in the list is selected.
> I tried to take enabled state into account when finding the approproate element to select, so the patch may be more involved than nessecary.
> I tested against ScriptApplication --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira