[GitHub] [hudi] jonvex commented on a diff in pull request #7394: [HUDI-5262] Allow hoodie.datasource.write.keygenerator.class to be used in spark-sql create table

["jonvex (via GitHub)" <gi...@apache.org>]

jonvex commented on code in PR #7394:
URL: https://github.com/apache/hudi/pull/7394#discussion_r1098026372


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -206,6 +206,18 @@ object HoodieWriterUtils {
     }
   }
 
+  /**
+   * In some contexts table config and the datasource write config are interchangeable.
+   * This is not usually the case so don't use this unless you are sure it is ok.
+   * */
+  def fixKeyGeneratorClassConfig(params: Map[String, String]): Map[String, String] = {

Review Comment:
   Can't make it private because it is used in other classes. I renamed it though



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -206,6 +206,18 @@ object HoodieWriterUtils {
     }
   }
 
+  /**
+   * In some contexts table config and the datasource write config are interchangeable.
+   * This is not usually the case so don't use this unless you are sure it is ok.
+   * */
+  def fixKeyGeneratorClassConfig(params: Map[String, String]): Map[String, String] = {

Review Comment:
   Also rebased



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org