[GitHub] [superset] betodealmeida commented on a change in pull request #17360: fix: Change datatype of column type in BaseColumn to allow larger datatype names for complexed columns

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17360:
URL: https://github.com/apache/superset/pull/17360#discussion_r767909810



##########
File path: UPDATING.md
##########
@@ -38,6 +38,7 @@ assists people when migrating to a new version.
 - [17539](https://github.com/apache/superset/pull/17539): all Superset CLI commands
   (init, load_examples and etc) require setting the FLASK_APP environment variable
   (which is set by default when .flaskenv is loaded)
+- [17360](https://github.com/apache/superset/pull/17360): changes the column type from `VARCHAR(32)` to `TEXT` in table `table_columns` could be a table lock on mysql dbs or take some time to complete on large deployments.

Review comment:
       ```suggestion
   - [17360](https://github.com/apache/superset/pull/17360): changes the column type from `VARCHAR(32)` to `TEXT` in table `table_columns`, potentially requiring a table lock on MySQL dbs or taking some time to complete on large deployments.
   ```

##########
File path: superset/migrations/versions/3ba29ecbaac5_change_datatype_of_type_in_basecolumn.py
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Change datatype of type in BaseColumn
+
+Revision ID: 3ba29ecbaac5
+Revises: b92d69a6643c
+Create Date: 2021-11-02 17:44:51.792138
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "3ba29ecbaac5"
+down_revision = "b92d69a6643c"

Review comment:
       I think your tests are failing because your migration is now introducing a second HEAD. You can change the down revision here and in line 20 to `abe27eaf93db` (which you can see if you run `superset db heads`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org