You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/12 07:27:07 UTC

[GitHub] [calcite] rubenada commented on pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

rubenada commented on pull request #1987:
URL: https://github.com/apache/calcite/pull/1987#issuecomment-643116159


   @xy2953396112 Please bear in mind that [CALCITE-4055 - RelFieldTrimmer loses hints](https://issues.apache.org/jira/browse/CALCITE-4055) ([PR#2015](https://github.com/apache/calcite/pull/2015)) has been merged, which leads to some conflicts in the current PR. Sorry for the inconvenience.
   Also, since you are adding the processing of Calc, which implements Hintable, you should take into consideration the guidelines from CALCITE-4055 in order to transfer the hints from the original Calc to the trimmed Calc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org