You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ai-yang (via GitHub)" <gi...@apache.org> on 2026/08/01 10:28:23 UTC

[PR] [studio][ISSUE #731] Keep instance updates atomic on save failures [rocketmq-dashboard]

ai-yang opened a new pull request, #732:
URL: https://github.com/apache/rocketmq-dashboard/pull/732

   Fixes #731
   
   ## What changed
   
   `InstanceService.updateInstance` now applies partial updates to a detached copy of the repository-owned instance and passes that copy to `InstanceRepository.save`.
   
   The copy preserves all six `InstanceVO` fields plus `id`, `createdAt`, and the previous `updatedAt`. This prevents a failed save from leaking rejected values into the in-memory repository while preserving successful partial-update behavior.
   
   ## Validation
   
   - Failure-path regression test: 20/20 consecutive runs on Java 21
   - Complete `InstanceServiceTest`: 23/23 tests passed
   - Complete server suite: 487/487 tests passed
   - `mvn package`: passed
   - Maven Checkstyle: passed
   - `git diff --check`: passed
   
   The project does not configure SpotBugs/FindBugs in its POM.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [studio][ISSUE #731] Keep instance updates atomic on save failures [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #732:
URL: https://github.com/apache/rocketmq-dashboard/pull/732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org