You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by weex-bot <gi...@git.apache.org> on 2017/03/21 18:09:09 UTC

[GitHub] incubator-weex issue #141: Class common's problem

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/141
  
    
    <!--
      1 failure:  Code file ios/sdk...
      14 warning:  These new JS file..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
      
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>Code file ios/sdk/WeexSDKTests/WXStorageTests.m does not have the copyright header.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>These new JS files do not have Flow enabled: test/scripts/components/image-onload.test.js, test/scripts/components/scroller-fixed.test.js</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXStyle.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/animation/WXAnimationModule.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/helper/WXStickyHelper.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/border/BorderDrawable.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/refresh/wrapper/BaseBounceView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/refresh/wrapper/BounceRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---