You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2018/11/22 22:54:04 UTC
spark git commit: [SPARK-24553][UI][FOLLOWUP] Fix unnecessary UI
redirect
Repository: spark
Updated Branches:
refs/heads/master 1d766f0e2 -> 76aae7f1f
[SPARK-24553][UI][FOLLOWUP] Fix unnecessary UI redirect
## What changes were proposed in this pull request?
This PR is a follow-up PR of #21600 to fix the unnecessary UI redirect.
## How was this patch tested?
Local verification
Closes #23116 from jerryshao/SPARK-24553.
Authored-by: jerryshao <je...@tencent.com>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/76aae7f1
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/76aae7f1
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/76aae7f1
Branch: refs/heads/master
Commit: 76aae7f1fd512f150ffcdb618107b12e1e97fe43
Parents: 1d766f0
Author: jerryshao <je...@tencent.com>
Authored: Thu Nov 22 14:54:00 2018 -0800
Committer: Dongjoon Hyun <do...@apache.org>
Committed: Thu Nov 22 14:54:00 2018 -0800
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala | 2 +-
.../main/scala/org/apache/spark/ui/storage/StoragePage.scala | 2 +-
.../scala/org/apache/spark/ui/storage/StoragePageSuite.scala | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/76aae7f1/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
index b9abd39..766efc1 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
@@ -368,7 +368,7 @@ private[ui] class StagePagedTable(
{if (cachedRddInfos.nonEmpty) {
Text("RDD: ") ++
cachedRddInfos.map { i =>
- <a href={s"$basePathUri/storage/rdd?id=${i.id}"}>{i.name}</a>
+ <a href={s"$basePathUri/storage/rdd/?id=${i.id}"}>{i.name}</a>
}
}}
<pre>{s.details}</pre>
http://git-wip-us.apache.org/repos/asf/spark/blob/76aae7f1/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala b/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
index 3eb546e..2488197 100644
--- a/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
@@ -78,7 +78,7 @@ private[ui] class StoragePage(parent: SparkUITab, store: AppStatusStore) extends
<tr>
<td>{rdd.id}</td>
<td>
- <a href={"%s/storage/rdd?id=%s".format(
+ <a href={"%s/storage/rdd/?id=%s".format(
UIUtils.prependBaseUri(request, parent.basePath), rdd.id)}>
{rdd.name}
</a>
http://git-wip-us.apache.org/repos/asf/spark/blob/76aae7f1/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala b/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
index cdc7f54..06f01a6 100644
--- a/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
+++ b/core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
@@ -81,19 +81,19 @@ class StoragePageSuite extends SparkFunSuite {
Seq("1", "rdd1", "Memory Deserialized 1x Replicated", "10", "100%", "100.0 B", "0.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(0) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
- Some("http://localhost:4040/storage/rdd?id=1"))
+ Some("http://localhost:4040/storage/rdd/?id=1"))
assert(((xmlNodes \\ "tr")(1) \\ "td").map(_.text.trim) ===
Seq("2", "rdd2", "Disk Serialized 1x Replicated", "5", "50%", "0.0 B", "200.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(1) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
- Some("http://localhost:4040/storage/rdd?id=2"))
+ Some("http://localhost:4040/storage/rdd/?id=2"))
assert(((xmlNodes \\ "tr")(2) \\ "td").map(_.text.trim) ===
Seq("3", "rdd3", "Disk Memory Serialized 1x Replicated", "10", "100%", "400.0 B", "500.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(2) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
- Some("http://localhost:4040/storage/rdd?id=3"))
+ Some("http://localhost:4040/storage/rdd/?id=3"))
}
test("empty rddTable") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org