You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/07 09:05:53 UTC

[GitHub] [incubator-seatunnel] simon824 opened a new pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

simon824 opened a new pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417


   
   
   ## Purpose of this pull request
   
   Fix Flink ConsoleSink not printing results
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] simon824 commented on pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417#issuecomment-1064695425


   cc @mans2singh @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417#issuecomment-1065207486


   Well done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] simon824 commented on pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417#issuecomment-1064700865


   > This can work, but I would like to print the cord in `writeRecord(Row record)` method, this might be the right hook method of `OutputFormat`.
   
   Yes i tried this method, it works, but `System.out.println` will trigger checkStyle exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417#issuecomment-1064706944


   > 
   
   Ok, I understand, it's ok to use print directly, since this sink plugin is just used in test case in most of the cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu merged pull request #1417: [Bug][Connector] Fix Flink ConsoleSink not printing results

Posted by GitBox <gi...@apache.org>.
wuchunfu merged pull request #1417:
URL: https://github.com/apache/incubator-seatunnel/pull/1417


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org