You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2013/02/15 18:57:13 UTC
[jira] [Comment Edited] (SOLR-4462) SolrJ's httpclient and httpcore
dependency versions should not be synchronized - instead, the httpcore
version to use should be drawn from the httpclient POM
[ https://issues.apache.org/jira/browse/SOLR-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579360#comment-13579360 ]
Steve Rowe edited comment on SOLR-4462 at 2/15/13 5:56 PM:
-----------------------------------------------------------
Patch downgrading SolrJ httpcore dependency from 4.2.3 to 4.2.2.
Comments added to solrj/ivy.xml discussing how to choose versions for httpcomponents httpmime and httpcore, based on the httpclient version.
{{ant precommit}} and {{ant validate-maven-dependencies}} both pass.
All Solr core, solrj, and Solr contrib tests pass, except ChaosMonkeySafeLeaderTest.testDistribSearch, which doesn't reliably reproduce (sometimes succeeds with a previously failing seed). It mostly fails for me though (4/5 trials) - it seems to be much slower (~4X) when it fails. I see Hoss already made an issue for this: SOLR-4454.
Committing shortly.
was (Author: steve_rowe):
Patch downgrading SoljJ httpcore dependency from 4.2.3 to 4.2.2.
Comments added to solrj/ivy.xml discussing how to choose versions for httpcomponents httpmime and httpcore, based on the httpclient version.
{{ant precommit}} and {{ant validate-maven-dependencies}} both pass.
All Solr core, solrj, and Solr contrib tests pass, except ChaosMonkeySafeLeaderTest.testDistribSearch, which doesn't reliably reproduce (sometimes succeeds with a previously failing seed). It mostly fails for me though (4/5 trials) - it seems to be much slower (~4X) when it fails. I see Hoss already made an issue for this: SOLR-4454.
Committing shortly.
> SolrJ's httpclient and httpcore dependency versions should not be synchronized - instead, the httpcore version to use should be drawn from the httpclient POM
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-4462
> URL: https://issues.apache.org/jira/browse/SOLR-4462
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0, 4.1
> Reporter: Steve Rowe
> Priority: Minor
> Attachments: SOLR-4462.patch
>
>
> The httpcomponents project, which hosts both the httpclient and the httpcore modules, uses Maven as its build system, so when the httpclient POM declares a dependency, it's authoritative (since that's how httpclient is built and tested). httpclient depends on httpcore, so the SolrJ httpcore version should be drawn from the httpclient POM.
> httpclient's httpcore dependency version doesn't always match the httpclient version. Recent examples (look for {{<httpcore.version>}} under {{<properties>}}):
> [https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.2.3/pom.xml]
> [http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.1.3/pom.xml]
> [http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.1.1/pom.xml]
> I'm fairly certain that these versions-out-of-sync incidents are not mistakes - I read this email exchange as describing intentionally versioning httpclient separately from httpcore: [http://markmail.org/thread/ippp4gbxwwnt6aws].
> SolrJ should separately version its httpclient and httpcore dependencies, and should draw the httpcore version from the httpclient POM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org