You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:03:13 UTC

[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on a change in pull request #20137: [v1.x][FEATURE][WIP] Add MKLDNN Deconvolution 1D and 3D support

PawelGlomski-Intel commented on a change in pull request #20137:
URL: https://github.com/apache/incubator-mxnet/pull/20137#discussion_r608739124



##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -471,8 +471,8 @@ def check_convolution_training(stype):
 @with_seed()
 def test_Deconvolution():
     def check_Deconvolution_training(stype):
-        for shape in [(3, 3, 10, 10)]: # testing only 2D for now
-            data_tmp = np.random.randint(256, size=shape)

Review comment:
       Was `randint(256, size=shape)` here for a reason? All other tests have `normal(-0.1, 1, size=shape)` for input values, could this be the reason why was this test flaky? I couldn't reproduce #12579 in my version of the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org