You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/31 12:59:41 UTC

[GitHub] [submarine] kevin85421 opened a new pull request #596: SUBMARINE-841. Modify hard-coded URLs in E2E test to soft-coded URLs

kevin85421 opened a new pull request #596:
URL: https://github.com/apache/submarine/pull/596


   ### What is this PR for?
   Currently, some frontend E2E tests determine whether a test passes or fails based on a hard-coded URL and port. Take dataIT as an example, the following code hard-coded the expected URL to "http://localhost:8080/workbench/data". However, we cannot ensure that Submarine Workbench will always run on "http://localhost:8080". Hence, this issue aims to change the hard-coded URL to a soft-coded URL.
   
    ```
   Assert.assertEquals(driver.getCurrentUrl(),"http://localhost:8080/workbench/data");
   ```
    
   Hardcoding vs Softcoding: https://simplicable.com/new/hardcoding-vs-softcoding
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-841
   
   ### How should this be tested?
   * Run workbench on $URL:$WORKBENCH_PORT (These two variables are specified in `run_frontend_e2e.sh`)
   ```
   cd submarine-cloud-v2
   ./hack/run_frontend_e2e.sh $[testcase]
   
   # Example: 
   ./hack/run_frontend_e2e.sh loginIT
   ./hack/run_frontend_e2e.sh environmentIT
   ```
   
   ### Screenshots (if appropriate)
   <img width="963" alt="截圖 2021-05-31 下午8 40 04" src="https://user-images.githubusercontent.com/20109646/120196922-fe085d80-c252-11eb-9aed-17a52c42478a.png">
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #596: SUBMARINE-841. Modify hard-coded URLs in E2E test to soft-coded URLs

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #596:
URL: https://github.com/apache/submarine/pull/596


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #596: SUBMARINE-841. Modify hard-coded URLs in E2E test to soft-coded URLs

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #596:
URL: https://github.com/apache/submarine/pull/596


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org