[GitHub] [flink] mxm commented on a change in pull request #11473: [FLINK-16705] Ensure MiniCluster shutdown does not interfere with JobResult retrieval

[GitBox <gi...@apache.org>]

mxm commented on a change in pull request #11473:
URL: https://github.com/apache/flink/pull/11473#discussion_r412111242



##########
File path: flink-core/src/main/java/org/apache/flink/core/execution/PipelineExecutor.java
##########
@@ -41,5 +41,5 @@
 	 * @param configuration the {@link Configuration} with the required execution parameters
 	 * @return a {@link CompletableFuture} with the {@link JobClient} corresponding to the pipeline.
 	 */
-	CompletableFuture<JobClient> execute(final Pipeline pipeline, final Configuration configuration) throws Exception;
+	CompletableFuture<? extends JobClient> execute(final Pipeline pipeline, final Configuration configuration) throws Exception;

Review comment:
       This was necessary to please Java generics when handling the derived JobClient class via futures. The alternative would have been to cast which we wanted to avoid. Since the class is marked `@Internal`, this should not be an issue?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org