You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "pegasas (via GitHub)" <gi...@apache.org> on 2023/12/11 04:56:28 UTC
[PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
pegasas opened a new pull request, #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
resolves https://github.com/apache/dolphinscheduler/issues/15224
## Brief change log
Add dolphinscheduler-e2e into root pom.
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie closed pull request #15306: [Improvement][E2E] Add dolphinscheduler-e2e into root pom
URL: https://github.com/apache/dolphinscheduler/pull/15306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306#discussion_r1443959662
##########
pom.xml:
##########
@@ -43,6 +43,7 @@
<module>dolphinscheduler-aop</module>
<module>dolphinscheduler-dao</module>
<module>dolphinscheduler-dist</module>
+ <module>dolphinscheduler-e2e</module>
Review Comment:
Good suggestion.
Already add module with profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306#discussion_r1423513830
##########
pom.xml:
##########
@@ -43,6 +43,7 @@
<module>dolphinscheduler-aop</module>
<module>dolphinscheduler-dao</module>
<module>dolphinscheduler-dist</module>
+ <module>dolphinscheduler-e2e</module>
Review Comment:
So it seems like we can close this issue?
due to having other concern on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306#discussion_r1429018591
##########
pom.xml:
##########
@@ -43,6 +43,7 @@
<module>dolphinscheduler-aop</module>
<module>dolphinscheduler-dao</module>
<module>dolphinscheduler-dist</module>
+ <module>dolphinscheduler-e2e</module>
Review Comment:
Can we use profile to prevent execute e2e case in normal compilation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306#discussion_r1423341420
##########
pom.xml:
##########
@@ -43,6 +43,7 @@
<module>dolphinscheduler-aop</module>
<module>dolphinscheduler-dao</module>
<module>dolphinscheduler-dist</module>
+ <module>dolphinscheduler-e2e</module>
Review Comment:
We should prevent the e2e module from participating in normal compilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] Add dolphinscheduler-e2e into root pom [dolphinscheduler]
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #15306:
URL: https://github.com/apache/dolphinscheduler/pull/15306#issuecomment-1908071419
keep the old org makes more sense in our project because we do not want to compile both e2e and api test to tarball, but we still thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org