You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/26 01:18:09 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
liuxiran opened a new pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [X] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
> @liuxiran FE ci failed after this pr got merged. Could you please take a look, please refer to https://github.com/apache/apisix-dashboard/runs/2430236911. Thanks.
come from: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-826267363
this pr tried to solve this unstable test case.
**Related issues**
None
**Checklist:**
- [X] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [X] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826441049
Deploy preview for *apisix-dashboard* processing.
Building with commit 907adfb74670483bb8fd1ebce8dcd7275d765e45
https://app.netlify.com/sites/apisix-dashboard/deploys/608614cb7accc60008b91034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826441049
Deploy preview for *apisix-dashboard* ready!
Built with commit 907adfb74670483bb8fd1ebce8dcd7275d765e45
https://deploy-preview-1826--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826445404
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1826](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (907adfb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2f3717fbcc22e88c0212feb082e8893ef903b011?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f3717f) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
+ Coverage 72.07% 72.14% +0.06%
==========================================
Files 125 125
Lines 2944 2944
Branches 711 711
==========================================
+ Hits 2122 2124 +2
+ Misses 822 820 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `72.14% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1826/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f3717f...907adfb](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826445404
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1826](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (907adfb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2f3717fbcc22e88c0212feb082e8893ef903b011?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f3717f) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
+ Coverage 72.07% 72.14% +0.06%
==========================================
Files 125 125
Lines 2944 2944
Branches 711 711
==========================================
+ Hits 2122 2124 +2
+ Misses 822 820 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `72.14% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1826/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f3717f...907adfb](https://codecov.io/gh/apache/apisix-dashboard/pull/1826?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826441049
Deploy preview for *apisix-dashboard* ready!
Built with commit 907adfb74670483bb8fd1ebce8dcd7275d765e45
https://deploy-preview-1826--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826#issuecomment-826441049
Deploy preview for *apisix-dashboard* processing.
Building with commit 907adfb74670483bb8fd1ebce8dcd7275d765e45
https://app.netlify.com/sites/apisix-dashboard/deploys/608614cb7accc60008b91034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1826: fix: unstable ci in create_and_edit_upstream_with_no_nodes.spec.js
Posted by GitBox <gi...@apache.org>.
imjoey merged pull request #1826:
URL: https://github.com/apache/apisix-dashboard/pull/1826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org