You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Renan DelValle <re...@apache.org> on 2018/03/19 23:33:57 UTC
Review Request 66154: Adding support for using custom executors via
the Aurora DSL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
Bugs: AURORA-1981
https://issues.apache.org/jira/browse/AURORA-1981
Repository: aurora
Description
-------
Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
First patch in a series to catch up on some work I have backlogged regarding custom executors.
Diffs
-----
RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
Diff: https://reviews.apache.org/r/66154/diff/1/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Renan DelValle
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Renan DelValle <re...@apache.org>.
> On March 19, 2018, 5:41 p.m., David McLaughlin wrote:
> > Not sure how possible it is given the requirement for a completely custom executor, but e2e coverage would be great.
Definitely possible, it's the end goal of going through my Aurora DSL backlog. I will most likely have to use DCE-GO (https://github.com/paypal/dce-go) in an e2e test after adding support to the DSL for the Mesos fetcher (https://issues.apache.org/jira/browse/AURORA-1982).
- Renan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199504
-----------------------------------------------------------
On March 19, 2018, 4:33 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 4:33 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199504
-----------------------------------------------------------
Not sure how possible it is given the requirement for a completely custom executor, but e2e coverage would be great.
- David McLaughlin
On March 19, 2018, 11:33 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:33 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199497
-----------------------------------------------------------
Ship it!
Master (b3fa9fe) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2018, 4:33 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 4:33 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199503
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On March 19, 2018, 11:33 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:33 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199578
-----------------------------------------------------------
Ship it!
src/test/python/apache/aurora/config/test_thrift.py
Lines 324 (patched)
<https://reviews.apache.org/r/66154/#comment279913>
Nit. check the `data` as well. The default config has data.
- Reza Motamedi
On March 19, 2018, 11:33 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:33 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199624
-----------------------------------------------------------
Ship it!
Master (b3fa9fe) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 20, 2018, 4:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/3/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199618
-----------------------------------------------------------
Ship it!
Master (b3fa9fe) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 20, 2018, 11:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 11:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199627
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On March 20, 2018, 4:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/3/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote:
> > docs/features/custom-executors.md
> > Line 151 (original), 151 (patched)
> > <https://reviews.apache.org/r/66154/diff/1/?file=1982652#file1982652line151>
> >
> > Link to http://aurora.apache.org/documentation/latest/features/custom-executors/ ?
>
> Renan DelValle wrote:
> Unless I misunderstood you, `docs/features/custom-executors.md` is converted to http://aurora.apache.org/documentation/latest/features/custom-executors/ when put through Rake2.0. So in this case the page would end up linking to itself :).
You are correct. Please ignore.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199509
-----------------------------------------------------------
On March 20, 2018, 4:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/3/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Renan DelValle <re...@apache.org>.
> On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote:
> > RELEASE-NOTES.md
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/66154/diff/1/?file=1982651#file1982651line7>
> >
> > s/---/-/g
Great catch!
> On March 20, 2018, 5:06 p.m., Santhosh Kumar Shanmugham wrote:
> > docs/features/custom-executors.md
> > Line 151 (original), 151 (patched)
> > <https://reviews.apache.org/r/66154/diff/1/?file=1982652#file1982652line151>
> >
> > Link to http://aurora.apache.org/documentation/latest/features/custom-executors/ ?
Unless I misunderstood you, `docs/features/custom-executors.md` is converted to http://aurora.apache.org/documentation/latest/features/custom-executors/ when put through Rake2.0. So in this case the page would end up linking to itself :).
- Renan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199509
-----------------------------------------------------------
On March 20, 2018, 4:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/#review199509
-----------------------------------------------------------
Fix it, then Ship it!
LGTM. +1 to adding an e2e test.
RELEASE-NOTES.md
Lines 7 (patched)
<https://reviews.apache.org/r/66154/#comment279807>
s/---/-/g
docs/features/custom-executors.md
Line 151 (original), 151 (patched)
<https://reviews.apache.org/r/66154/#comment279941>
Link to http://aurora.apache.org/documentation/latest/features/custom-executors/ ?
- Santhosh Kumar Shanmugham
On March 20, 2018, 4:24 p.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66154/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:24 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: AURORA-1981
> https://issues.apache.org/jira/browse/AURORA-1981
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
>
> First patch in a series to catch up on some work I have backlogged regarding custom executors.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
> docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
> docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
> src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
> src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
> src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
> src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
>
>
> Diff: https://reviews.apache.org/r/66154/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 66154: Adding support for using custom executors
via the Aurora DSL
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66154/
-----------------------------------------------------------
(Updated March 20, 2018, 4:24 p.m.)
Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Adding check for ExecutorConfig.Data when using Thermos as requested by Reza.
Bugs: AURORA-1981
https://issues.apache.org/jira/browse/AURORA-1981
Repository: aurora
Description
-------
Adding executor_config as a field to MesosJob in order to allow the use of custom executors through the DSL.
First patch in a series to catch up on some work I have backlogged regarding custom executors.
Diffs (updated)
-----
RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2
docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293
docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16
src/main/python/apache/aurora/config/schema/base.py 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c
src/main/python/apache/aurora/config/thrift.py dcabb03500c8e60d5585f0e65c74e163bd93e43a
src/test/python/apache/aurora/client/cli/test_inspect.py 8c624800eed383383dfb07c10aae103c54875728
src/test/python/apache/aurora/config/test_thrift.py 7bf050836633780401c5d8a371e006bde025c420
Diff: https://reviews.apache.org/r/66154/diff/2/
Changes: https://reviews.apache.org/r/66154/diff/1-2/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Renan DelValle