You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (Created) (JIRA)" <ji...@apache.org> on 2012/02/22 02:36:48 UTC
[jira] [Created] (HBASE-5439) Fix some performance findbugs issues
Fix some performance findbugs issues
------------------------------------
Key: HBASE-5439
URL: https://issues.apache.org/jira/browse/HBASE-5439
Project: HBase
Issue Type: Improvement
Components: performance
Affects Versions: 0.94.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Minor
Given 0.94 is the "performance" release, I took a look at some performance findbugs.
This patch should fixeall of the following types of findbugs (except one case in generated code):
Bug type DM_NUMBER_CTOR
Bug type DM_STRING_CTOR
Bug type DM_BOOLEAN_CTOR
(these are simple constructor issues where Type.valueOf is more efficient
Fixes one of:
Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5439) Fix some performance findbugs
issues
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213196#comment-13213196 ]
Hadoop QA commented on HBASE-5439:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515519/HBASE-5439.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 151 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1001//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1001//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1001//console
This message is automatically generated.
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5439) Fix some performance findbugs issues
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5439:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5439) Fix some performance findbugs issues
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5439:
---------------------------------
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5439) Fix some performance findbugs issues
Posted by "Gregory Chanan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5439:
----------------------------------
Attachment: HBASE-5439.patch
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5439) Fix some performance findbugs issues
Posted by "Gregory Chanan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5439:
----------------------------------
Status: Patch Available (was: Open)
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5439) Fix some performance findbugs
issues
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213339#comment-13213339 ]
stack commented on HBASE-5439:
------------------------------
+1
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5439) Fix some performance findbugs
issues
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213406#comment-13213406 ]
Lars Hofhansl commented on HBASE-5439:
--------------------------------------
Committed to trunk. Thanks for the patch.
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5439) Fix some performance findbugs
issues
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213181#comment-13213181 ]
Lars Hofhansl commented on HBASE-5439:
--------------------------------------
Thanks for doing this Gregory. Patch looks good, I'll commit later tonight if nobody objects and tests pass.
> Fix some performance findbugs issues
> ------------------------------------
>
> Key: HBASE-5439
> URL: https://issues.apache.org/jira/browse/HBASE-5439
> Project: HBase
> Issue Type: Improvement
> Components: performance
> Affects Versions: 0.94.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5439.patch
>
>
> Given 0.94 is the "performance" release, I took a look at some performance findbugs.
> This patch should fixeall of the following types of findbugs (except one case in generated code):
> Bug type DM_NUMBER_CTOR
> Bug type DM_STRING_CTOR
> Bug type DM_BOOLEAN_CTOR
> (these are simple constructor issues where Type.valueOf is more efficient
> Fixes one of:
> Bug type SIC_INNER_SHOULD_BE_STATIC (Inner class should be static)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira