You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ArcherShao <gi...@git.apache.org> on 2015/04/15 08:59:10 UTC
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
GitHub user ArcherShao opened a pull request:
https://github.com/apache/spark/pull/5519
[Minor] Alter description of some configuration in yarn and mesos
The value of these configurations are calculate by 'math.max(a, b)', but description is 'a with minimum of b', alter it to 'a with maximum of b''.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ArcherShao/spark conf-des
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5519
----
commit 7d23311dffb919a44bb8e0559159fb616771b59c
Author: ArcherShao <sh...@huawei.com>
Date: 2015-04-15T06:50:17Z
[Minor] Alter description of some configuration in yarn and mesos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5519#issuecomment-93226322
[Test build #30324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30324/consoleFull) for PR 5519 at commit [`7d23311`](https://github.com/apache/spark/commit/7d23311dffb919a44bb8e0559159fb616771b59c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5519#issuecomment-93260085
[Test build #30324 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30324/consoleFull) for PR 5519 at commit [`7d23311`](https://github.com/apache/spark/commit/7d23311dffb919a44bb8e0559159fb616771b59c).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by ArcherShao <gi...@git.apache.org>.
Github user ArcherShao commented on the pull request:
https://github.com/apache/spark/pull/5519#issuecomment-93244469
Ok, I got it, thanks a lot, I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5519#issuecomment-93260088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30324/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by ArcherShao <gi...@git.apache.org>.
Github user ArcherShao closed the pull request at:
https://github.com/apache/spark/pull/5519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Minor] Alter description of some configuratio...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5519#issuecomment-93240866
No, this is wrong. The value of `max(foo, bar)` is always at _minimum_ the value of bar. It is how you enforce that the result is foo, unless it's smaller than the desired minimum, bar, in which case bar. Mind closing this PR please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org