You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "ramackri (via GitHub)" <gi...@apache.org> on 2026/08/19 10:01:39 UTC
[PR] ATLAS-5385: Rename header authentication config to atlas.authentication.method.header.* [atlas]
ramackri opened a new pull request, #735:
URL: https://github.com/apache/atlas/pull/735
## Summary
- Replace legacy `atlas.authn.header.*` properties with `atlas.authentication.header.enabled` and `atlas.authentication.method.header.<logical-key>` mappings
- Add `AtlasHeaderAuthConfiguration` to resolve logical keys (`username`, `roles`, `request-id`) to configurable HTTP header names
- Refactor `AtlasHeaderPreAuthFilter` to use the new configuration model while preserving existing request-id behavior via the `atlas.request.id` request attribute
- Remove vendor-specific header names from default property examples and tests
## Migration
```properties
# Before
atlas.authn.header.enabled=true
atlas.authn.header.username=<header-name>
atlas.authn.header.roles=<header-name>
atlas.authn.header.requestid=<header-name>
# After
atlas.authentication.header.enabled=true
atlas.authentication.method.header.username=<header-name>
atlas.authentication.method.header.roles=<header-name>
atlas.authentication.method.header.request-id=<header-name>
```
## Test plan
- [ ] Enable header auth with username/roles/request-id mappings in `atlas-application.properties`
- [ ] Verify API access with curl using configured identity headers
- [ ] Verify requests without username header remain unauthenticated via header auth
- [ ] Verify request-id is propagated only for successful header-auth (`TRUSTED_PROXY`) requests
- [ ] Run `AtlasHeaderAuthConfigurationTest` and `AtlasHeaderPreAuthFilterTest`
https://issues.apache.org/jira/browse/ATLAS-5385
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5385: Rename header authentication config to atlas.authentication.method.header.* [atlas]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #735:
URL: https://github.com/apache/atlas/pull/735#discussion_r3815395139
##########
distro/src/conf/atlas-application.properties:
##########
@@ -164,6 +164,12 @@ atlas.authentication.method.file.filename=${sys:atlas.home}/conf/users-credentia
#atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
#atlas.authentication.method.ldap.ad.default.role=<default role>
+######### Header Based Authentication #########
+#atlas.authentication.header.enabled=false
Review Comment:
`atlas.authentication.header` => `atlas.authentication.method.header` - to be consistent with existing configuration names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5385: Rename header authentication config to atlas.authentication.method.header.* [atlas]
Posted by "nixonrodrigues (via GitHub)" <gi...@apache.org>.
nixonrodrigues merged PR #735:
URL: https://github.com/apache/atlas/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5385: Rename header authentication config to atlas.authentication.method.header.* [atlas]
Posted by "ramackri (via GitHub)" <gi...@apache.org>.
ramackri commented on code in PR #735:
URL: https://github.com/apache/atlas/pull/735#discussion_r3818332042
##########
distro/src/conf/atlas-application.properties:
##########
@@ -164,6 +164,12 @@ atlas.authentication.method.file.filename=${sys:atlas.home}/conf/users-credentia
#atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
#atlas.authentication.method.ldap.ad.default.role=<default role>
+######### Header Based Authentication #########
+#atlas.authentication.header.enabled=false
Review Comment:
Updated — enable flag is now atlas.authentication.method.header.enabled for consistency with other atlas.authentication.method.* properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5385: Rename header authentication config to atlas.authentication.method.header.* [atlas]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on code in PR #735:
URL: https://github.com/apache/atlas/pull/735#discussion_r3814431112
##########
distro/src/conf/atlas-application.properties:
##########
@@ -297,7 +297,7 @@ atlas.rest.notification.enableTLS=false
#atlas.skip.check.for.parent.child.attribute.name=true
######### Header Based Authentication #########
-#atlas.authn.header.enabled=false
-#atlas.authn.header.username=x-awc-username
-#atlas.authn.header.roles=x-awc-roles
-#atlas.authn.header.requestid=x-awc-requestid
\ No newline at end of file
+#atlas.authentication.header.enabled=false
Review Comment:
I suggest moving lines 299 to 303 to line 165, to keep all authentication related properties together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org