You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/10 20:46:25 UTC

[kudu-CR] [macOS] fix security test failures

Hello Todd Lipcon, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6346

to review the following change.

Change subject: [macOS] fix security test failures
......................................................................

[macOS] fix security test failures

Change-Id: I5c4d464edc09f41151f95ad2f0e694f2bc00b0f0
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/init.cc
4 files changed, 13 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/6346/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c4d464edc09f41151f95ad2f0e694f2bc00b0f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [macOS] fix security test failures

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [macOS] fix security test failures
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d464edc09f41151f95ad2f0e694f2bc00b0f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [macOS] fix security test failures

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: [macOS] fix security test failures
......................................................................


[macOS] fix security test failures

Change-Id: I5c4d464edc09f41151f95ad2f0e694f2bc00b0f0
Reviewed-on: http://gerrit.cloudera.org:8080/6346
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/security/init.cc
4 files changed, 13 insertions(+), 27 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c4d464edc09f41151f95ad2f0e694f2bc00b0f0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>