You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "douglasdennis (via GitHub)" <gi...@apache.org> on 2023/03/08 02:13:54 UTC
[GitHub] [sedona] douglasdennis opened a new pull request, #791: [SEDONA-229] Fix Linter Issues in Viz
douglasdennis opened a new pull request, #791:
URL: https://github.com/apache/sedona/pull/791
## Did you read the Contributor Guide?
- Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-229.
## What changes were proposed in this PR?
This PR addresses several linter issues in the sedona viz module. All of the fixes for these issues involve no real structural code changes, just formatting and being more explicit with imports. The types of changes in this PR:
- Ignore imports from AWT, which is apparently an "illegal" import according to the linter. These seem mandatory for the viz module.
- Wildcard imports were replaced with explicit imports for the classes needed.
- An import was moved from inside of a method to be at the top.
- Add spaces around a comment and plus operators.
- Fixed long lines. I attempted to use the style guide located at https://docs.scala-lang.org/style/ If I got something wrong then please let me know.
- Added newlines to the ends of files.
## How was this patch tested?
Standard build process with unit tests.
## Did this PR include necessary documentation updates?
- No, this PR does not affect any public API so no need to change the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] douglasdennis commented on pull request #791: [SEDONA-229] Fix Linter Issues in Viz
Posted by "douglasdennis (via GitHub)" <gi...@apache.org>.
douglasdennis commented on PR #791:
URL: https://github.com/apache/sedona/pull/791#issuecomment-1459470723
@jiayuasu I found scalafmt (https://scalameta.org/scalafmt/). It looks like spotless (https://github.com/diffplug/spotless/tree/main/plugin-maven) uses it to handle Scala code as a maven plugin. I can explore that for handling the formatting related linter messages.
Would there be any interest to add this as a check to the build process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu commented on pull request #791: [SEDONA-229] Fix Linter Issues in Viz
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #791:
URL: https://github.com/apache/sedona/pull/791#issuecomment-1459565865
@douglasdennis I think spotless is nice. Let's have it in Sedona. I think we should put it in the build process. Should we allow the build process automatically fix the format, or let the build process fail and we manually call `mvn spotless:apply` to fix it?
I kind of prefer the auto fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu commented on pull request #791: [SEDONA-229] Fix Linter Issues in Viz
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #791:
URL: https://github.com/apache/sedona/pull/791#issuecomment-1459430441
@douglasdennis This is perfectly fine. However, I wonder if scala has something similar to https://code.revelc.net/formatter-maven-plugin/ in the Java world. This will automatically fix styling issues instead of manually doing the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu merged pull request #791: [SEDONA-229] Fix Linter Issues in Viz
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #791:
URL: https://github.com/apache/sedona/pull/791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] douglasdennis commented on pull request #791: [SEDONA-229] Fix Linter Issues in Viz
Posted by "douglasdennis (via GitHub)" <gi...@apache.org>.
douglasdennis commented on PR #791:
URL: https://github.com/apache/sedona/pull/791#issuecomment-1459162631
This doesn't fix all linter issues in viz. There will be several follow up PRs to address issues that require real code/config changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org