You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/08 06:39:11 UTC

Review Request 65566: Returned profiles based on provider selectors in UriDiskProfileAdaptor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65566/
-----------------------------------------------------------

Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Bugs: MESOS-8510
    https://issues.apache.org/jira/browse/MESOS-8510


Repository: mesos


Description
-------

Now the URI disk profile adaptor module will return the set of profiles
in which each profile is either known to a storage resource provider or
applies to it (based on the resource provider selector) when it watches
for profiles.


Diffs
-----

  src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9 
  src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f 


Diff: https://reviews.apache.org/r/65566/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 65566: Returned profiles based on provider selectors in UriDiskProfileAdaptor.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65566/#review197122
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2018, 6:39 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65566/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2018, 6:39 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
>     https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the URI disk profile adaptor module will return the set of profiles
> in which each profile is either known to a storage resource provider or
> applies to it (based on the resource provider selector) when it watches
> for profiles.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9 
>   src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f 
> 
> 
> Diff: https://reviews.apache.org/r/65566/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 65566: Returned profiles based on provider selectors in UriDiskProfileAdaptor.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65566/#review197075
-----------------------------------------------------------



PASS: Mesos patch 65566 was successfully built and tested.

Reviews applied: `['65553', '65554', '65538', '65558', '65559', '65566']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65566

- Mesos Reviewbot Windows


On Feb. 8, 2018, 6:39 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65566/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2018, 6:39 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
>     https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the URI disk profile adaptor module will return the set of profiles
> in which each profile is either known to a storage resource provider or
> applies to it (based on the resource provider selector) when it watches
> for profiles.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile.hpp 2f4fc7cededeb41afe329e1315569e097b1a60f9 
>   src/resource_provider/storage/uri_disk_profile.cpp 7372b290d4fc3e45dc83fb3dd759150d08b7541f 
> 
> 
> Diff: https://reviews.apache.org/r/65566/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>