You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/10 06:57:29 UTC

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #763: Update EXTRADEFINES macro to be used by make via command line

liuguo09 opened a new pull request #763: Update EXTRADEFINES macro to be used by make via command line
URL: https://github.com/apache/incubator-nuttx/pull/763
 
 
   1. So call 'make EXTRADEFINES=-Wno-cpp' could suppress the warnings with
   pre-processor directive #warning in GCC.
   2. Call 'tools/testbuild.sh -e -Wno-cpp testlist' would pass "EXTRADEFINES=-Wno-cpp"
   to make command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] yamt commented on issue #763: Update EXTRADEFINES macro to be used by make via command line

Posted by GitBox <gi...@apache.org>.
yamt commented on issue #763: Update EXTRADEFINES macro to be used by make via command line
URL: https://github.com/apache/incubator-nuttx/pull/763#issuecomment-611965993
 
 
   it seems like a bit abuse as -Wno-cpp is not "defines". otherwise lgtm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #763: Use EXTRAFLAGS instead of EXTRADEFINES to be used by make via command line

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #763: Use EXTRAFLAGS instead of EXTRADEFINES to be used by make via command line
URL: https://github.com/apache/incubator-nuttx/pull/763#issuecomment-612336748
 
 
   @patacongo please review this patch which is the first step to enable warning as error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #763: Update EXTRADEFINES macro to be used by make via command line

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #763: Update EXTRADEFINES macro to be used by make via command line
URL: https://github.com/apache/incubator-nuttx/pull/763#issuecomment-612025877
 
 
   > it seems like a bit abuse as -Wno-cpp is not "defines". otherwise lgtm.
   
   Ok, @liuguo09 will provide an update

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #763: Use EXTRAFLAGS instead of EXTRADEFINES to be used by make via command line

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #763: Use EXTRAFLAGS instead of EXTRADEFINES to be used by make via command line
URL: https://github.com/apache/incubator-nuttx/pull/763
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services