You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/12/07 23:56:18 UTC
[jira] Created: (CASSANDRA-608) r/m dead code from MerkleTree,
AntiEntropyService
r/m dead code from MerkleTree, AntiEntropyService
-------------------------------------------------
Key: CASSANDRA-608
URL: https://issues.apache.org/jira/browse/CASSANDRA-608
Project: Cassandra
Issue Type: Task
Components: Core
Reporter: Jonathan Ellis
Assignee: Stu Hood
Fix For: 0.5
method parameters in MerkleTree are the worst offenders
http://wiki.apache.org/cassandra/RunningCassandraInIDEA describes how to set up Cassandra in IDEA; the OSS build from http://jetbrains.org/ is fine. alternatively, Eric assures me that Eclipse can also identify dead code easily but we don't have a wiki page for that. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-608) r/m dead code from MerkleTree,
AntiEntropyService
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-608:
-------------------------------
Attachment: 608-dead-code.diff
Eclipse didn't find 'half-a-dozen', but here is a patch fixing the issues it did find.
Thanks!
> r/m dead code from MerkleTree, AntiEntropyService
> -------------------------------------------------
>
> Key: CASSANDRA-608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-608
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Fix For: 0.5
>
> Attachments: 608-dead-code.diff
>
>
> method parameters in MerkleTree are the worst offenders
> http://wiki.apache.org/cassandra/RunningCassandraInIDEA describes how to set up Cassandra in IDEA; the OSS build from http://jetbrains.org/ is fine. alternatively, Eric assures me that Eclipse can also identify dead code easily but we don't have a wiki page for that. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-608) r/m dead code from MerkleTree,
AntiEntropyService
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788072#action_12788072 ]
Hudson commented on CASSANDRA-608:
----------------------------------
Integrated in Cassandra #282 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/282/])
r/m unused code. patch by Stu Hood; reviewed by jbellis for
> r/m dead code from MerkleTree, AntiEntropyService
> -------------------------------------------------
>
> Key: CASSANDRA-608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-608
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Fix For: 0.5
>
> Attachments: 608-dead-code.diff, 608-dead-code.diff
>
>
> method parameters in MerkleTree are the worst offenders
> http://wiki.apache.org/cassandra/RunningCassandraInIDEA describes how to set up Cassandra in IDEA; the OSS build from http://jetbrains.org/ is fine. alternatively, Eric assures me that Eclipse can also identify dead code easily but we don't have a wiki page for that. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-608) r/m dead code from MerkleTree,
AntiEntropyService
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787646#action_12787646 ]
Jonathan Ellis commented on CASSANDRA-608:
------------------------------------------
post-patch, idea reports these as still unused:
invalidateHelper: pright
compactHelper: pleft, pright
> r/m dead code from MerkleTree, AntiEntropyService
> -------------------------------------------------
>
> Key: CASSANDRA-608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-608
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Fix For: 0.5
>
> Attachments: 608-dead-code.diff
>
>
> method parameters in MerkleTree are the worst offenders
> http://wiki.apache.org/cassandra/RunningCassandraInIDEA describes how to set up Cassandra in IDEA; the OSS build from http://jetbrains.org/ is fine. alternatively, Eric assures me that Eclipse can also identify dead code easily but we don't have a wiki page for that. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-608) r/m dead code from MerkleTree,
AntiEntropyService
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-608:
-------------------------------
Attachment: 608-dead-code.diff
Ah, interesting. I guess Idea can catch parameters that are only used recursively.
New patch. Thanks!
> r/m dead code from MerkleTree, AntiEntropyService
> -------------------------------------------------
>
> Key: CASSANDRA-608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-608
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Fix For: 0.5
>
> Attachments: 608-dead-code.diff, 608-dead-code.diff
>
>
> method parameters in MerkleTree are the worst offenders
> http://wiki.apache.org/cassandra/RunningCassandraInIDEA describes how to set up Cassandra in IDEA; the OSS build from http://jetbrains.org/ is fine. alternatively, Eric assures me that Eclipse can also identify dead code easily but we don't have a wiki page for that. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.